From 5dbe1c6ea66ce00ebefd4f8cc95cced9ec5c5291 Mon Sep 17 00:00:00 2001 From: Hemant Kumar Date: Thu, 12 Dec 2024 08:24:44 -0500 Subject: [PATCH 1/2] Give delete permissions to snapshot-operator role for removing webhook deployment --- .../snapshotcontroller/assets/05_operator_role-hypershift.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/control-plane-operator/controllers/hostedcontrolplane/snapshotcontroller/assets/05_operator_role-hypershift.yaml b/control-plane-operator/controllers/hostedcontrolplane/snapshotcontroller/assets/05_operator_role-hypershift.yaml index e4a091c414..d33363a55b 100644 --- a/control-plane-operator/controllers/hostedcontrolplane/snapshotcontroller/assets/05_operator_role-hypershift.yaml +++ b/control-plane-operator/controllers/hostedcontrolplane/snapshotcontroller/assets/05_operator_role-hypershift.yaml @@ -27,6 +27,7 @@ rules: - create - update - patch + - delete - apiGroups: - policy resources: @@ -38,6 +39,7 @@ rules: - create - update - patch + - delete - apiGroups: - "" resources: @@ -51,6 +53,7 @@ rules: - create - update - patch + - delete - apiGroups: - "" resources: From dc71d05a6bfe021f9a227346481fde6702117fd6 Mon Sep 17 00:00:00 2001 From: Hemant Kumar Date: Thu, 12 Dec 2024 11:37:37 -0500 Subject: [PATCH 2/2] Add a comment about hypershift file being a copy of cluster-csi-operator file --- .../assets/05_operator_role-hypershift.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/control-plane-operator/controllers/hostedcontrolplane/snapshotcontroller/assets/05_operator_role-hypershift.yaml b/control-plane-operator/controllers/hostedcontrolplane/snapshotcontroller/assets/05_operator_role-hypershift.yaml index d33363a55b..179e5bab08 100644 --- a/control-plane-operator/controllers/hostedcontrolplane/snapshotcontroller/assets/05_operator_role-hypershift.yaml +++ b/control-plane-operator/controllers/hostedcontrolplane/snapshotcontroller/assets/05_operator_role-hypershift.yaml @@ -1,4 +1,6 @@ -# *** AUTOMATICALLY GENERATED FILE - DO NOT EDIT *** +# This is a copy of https://github.com/openshift/cluster-csi-snapshot-controller-operator/blob/master/manifests/05_operator_role-hypershift.yaml +# Do not edit this file directly here. If you need to change this file, change first in +# cluster-csi-snapshot-controller-operator and then copy the file. apiVersion: rbac.authorization.k8s.io/v1 kind: Role metadata: