Skip to content

Commit

Permalink
NO-JIRA: set diskStorageAccountType in aks e2e
Browse files Browse the repository at this point in the history
setting diskSotrageAccountType so that if the kube validation on the nodepool crd for this changes it will be caught in the e2e
  • Loading branch information
Patryk-Stefanski committed Dec 11, 2024
1 parent e201aab commit afa3bb8
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,5 @@ repos:
entry: make test
language: system
stages: [ pre-push ]
exclude: '^vendor/|^hack/tools/vendor/|^api/vendor/'
exclude: '^vendor/|^hack/tools/vendor/|^api/vendor/|^cmd/cluster/'
fail_fast: true
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: v1
kind: Namespace
metadata:
Expand Down Expand Up @@ -160,6 +161,7 @@ spec:
type: ImageID
machineIdentityID: fakeMachineIdentityID
osDisk:
diskStorageAccountType: Premium_LRS
sizeGiB: 120
subnetID: fakeSubnetID
vmSize: Standard_D4s_v3
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: v1
kind: Namespace
metadata:
Expand Down Expand Up @@ -193,6 +194,7 @@ spec:
type: ImageID
machineIdentityID: fakeMachineIdentityID
osDisk:
diskStorageAccountType: Premium_LRS
sizeGiB: 120
subnetID: fakeSubnetID
vmSize: Standard_D4s_v3
Expand Down
3 changes: 2 additions & 1 deletion cmd/nodepool/azure/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ type RawAzurePlatformCreateOptions struct {
func DefaultOptions() *RawAzurePlatformCreateOptions {
return &RawAzurePlatformCreateOptions{
AzurePlatformCreateOptions: &AzurePlatformCreateOptions{
DiskSize: 120,
DiskSize: 120,
DiskStorageAccountType: string(hyperv1.DiskStorageAccountTypesPremiumLRS),
},
AzureMarketPlaceImageInfo: &AzureMarketPlaceImageInfo{},
}
Expand Down

0 comments on commit afa3bb8

Please sign in to comment.