From cd8717464fbcbbad4bc7984a127c313169c4f138 Mon Sep 17 00:00:00 2001 From: pstefans Date: Wed, 11 Dec 2024 19:22:02 +0000 Subject: [PATCH] NO-JIRA: set diskStorageAccountType in aks e2e setting diskSotrageAccountType so that if the kube validation on the nodepool crd for this changes it will be caught in the e2e --- ...re_TestCreateCluster_minimal_flags_necessary_to_render.yaml | 1 + .../zz_fixture_TestCreateCluster_with_availability_ones.yaml | 2 ++ cmd/nodepool/azure/create.go | 3 ++- 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/cmd/cluster/azure/testdata/zz_fixture_TestCreateCluster_minimal_flags_necessary_to_render.yaml b/cmd/cluster/azure/testdata/zz_fixture_TestCreateCluster_minimal_flags_necessary_to_render.yaml index 0d3ce9008b..17e5d1634c 100644 --- a/cmd/cluster/azure/testdata/zz_fixture_TestCreateCluster_minimal_flags_necessary_to_render.yaml +++ b/cmd/cluster/azure/testdata/zz_fixture_TestCreateCluster_minimal_flags_necessary_to_render.yaml @@ -160,6 +160,7 @@ spec: type: ImageID machineIdentityID: fakeMachineIdentityID osDisk: + diskStorageAccountType: Premium_LRS sizeGiB: 120 subnetID: fakeSubnetID vmSize: Standard_D4s_v3 diff --git a/cmd/cluster/azure/testdata/zz_fixture_TestCreateCluster_with_availability_ones.yaml b/cmd/cluster/azure/testdata/zz_fixture_TestCreateCluster_with_availability_ones.yaml index 686a0fbc9a..8842db2def 100644 --- a/cmd/cluster/azure/testdata/zz_fixture_TestCreateCluster_with_availability_ones.yaml +++ b/cmd/cluster/azure/testdata/zz_fixture_TestCreateCluster_with_availability_ones.yaml @@ -161,6 +161,7 @@ spec: type: ImageID machineIdentityID: fakeMachineIdentityID osDisk: + diskStorageAccountType: Premium_LRS sizeGiB: 120 subnetID: fakeSubnetID vmSize: Standard_D4s_v3 @@ -193,6 +194,7 @@ spec: type: ImageID machineIdentityID: fakeMachineIdentityID osDisk: + diskStorageAccountType: Premium_LRS sizeGiB: 120 subnetID: fakeSubnetID vmSize: Standard_D4s_v3 diff --git a/cmd/nodepool/azure/create.go b/cmd/nodepool/azure/create.go index c858e76c1c..eac66d3f35 100644 --- a/cmd/nodepool/azure/create.go +++ b/cmd/nodepool/azure/create.go @@ -47,7 +47,8 @@ type RawAzurePlatformCreateOptions struct { func DefaultOptions() *RawAzurePlatformCreateOptions { return &RawAzurePlatformCreateOptions{ AzurePlatformCreateOptions: &AzurePlatformCreateOptions{ - DiskSize: 120, + DiskSize: 120, + DiskStorageAccountType: string(hyperv1.DiskStorageAccountTypesPremiumLRS), }, AzureMarketPlaceImageInfo: &AzureMarketPlaceImageInfo{}, }