Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-2135: Bring latest changes for snapshotter #166

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Nov 22, 2024

tosi3k and others added 30 commits September 9, 2024 13:28
Use protobuf encoding for core K8s APIs in external-snapshotter
…tlist

Add and set the new VolumeSnapshotHandlePairList field
this commit adds new parameter keys for
getvolumegroupsnapshot

Signed-off-by: yati1998 <ypadia@redhat.com>
Bumps the github-dependencies group with 8 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [github.com/fsnotify/fsnotify](https://github.com/fsnotify/fsnotify) | `1.7.0` | `1.8.0` |
| [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) | `1.20.2` | `1.20.5` |
| [github.com/prometheus/common](https://github.com/prometheus/common) | `0.55.0` | `0.60.1` |
| [google.golang.org/grpc](https://github.com/grpc/grpc-go) | `1.65.0` | `1.67.1` |
| google.golang.org/protobuf | `1.34.2` | `1.35.1` |
| [github.com/klauspost/compress](https://github.com/klauspost/compress) | `1.17.9` | `1.17.11` |
| [go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc](https://github.com/open-telemetry/opentelemetry-go-contrib) | `0.54.0` | `0.56.0` |
| [golang.org/x/time](https://github.com/golang/time) | `0.6.0` | `0.7.0` |



Updates `github.com/fsnotify/fsnotify` from 1.7.0 to 1.8.0
- [Release notes](https://github.com/fsnotify/fsnotify/releases)
- [Changelog](https://github.com/fsnotify/fsnotify/blob/main/CHANGELOG.md)
- [Commits](fsnotify/fsnotify@v1.7.0...v1.8.0)

Updates `github.com/prometheus/client_golang` from 1.20.2 to 1.20.5
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.20.2...v1.20.5)

Updates `github.com/prometheus/common` from 0.55.0 to 0.60.1
- [Release notes](https://github.com/prometheus/common/releases)
- [Changelog](https://github.com/prometheus/common/blob/main/RELEASE.md)
- [Commits](prometheus/common@v0.55.0...v0.60.1)

Updates `google.golang.org/grpc` from 1.65.0 to 1.67.1
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.65.0...v1.67.1)

Updates `google.golang.org/protobuf` from 1.34.2 to 1.35.1

Updates `github.com/klauspost/compress` from 1.17.9 to 1.17.11
- [Release notes](https://github.com/klauspost/compress/releases)
- [Changelog](https://github.com/klauspost/compress/blob/master/.goreleaser.yml)
- [Commits](klauspost/compress@v1.17.9...v1.17.11)

Updates `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc` from 0.54.0 to 0.56.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.54.0...zpages/v0.56.0)

Updates `go.opentelemetry.io/otel` from 1.29.0 to 1.31.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.29.0...v1.31.0)

Updates `go.opentelemetry.io/otel/metric` from 1.29.0 to 1.31.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.29.0...v1.31.0)

Updates `go.opentelemetry.io/otel/trace` from 1.29.0 to 1.31.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.29.0...v1.31.0)

Updates `golang.org/x/net` from 0.28.0 to 0.30.0
- [Commits](golang/net@v0.28.0...v0.30.0)

Updates `golang.org/x/oauth2` from 0.22.0 to 0.23.0
- [Commits](golang/oauth2@v0.22.0...v0.23.0)

Updates `golang.org/x/sys` from 0.24.0 to 0.26.0
- [Commits](golang/sys@v0.24.0...v0.26.0)

Updates `golang.org/x/term` from 0.23.0 to 0.25.0
- [Commits](golang/term@v0.23.0...v0.25.0)

Updates `golang.org/x/text` from 0.17.0 to 0.19.0
- [Release notes](https://github.com/golang/text/releases)
- [Commits](golang/text@v0.17.0...v0.19.0)

Updates `golang.org/x/time` from 0.6.0 to 0.7.0
- [Commits](golang/time@v0.6.0...v0.7.0)

Updates `google.golang.org/genproto/googleapis/rpc` from 0.0.0-20240822170219-fc7c04adadcd to 0.0.0-20241007155032-5fefd90f89a9
- [Commits](https://github.com/googleapis/go-genproto/commits)

---
updated-dependencies:
- dependency-name: github.com/fsnotify/fsnotify
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: github.com/prometheus/common
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: github.com/klauspost/compress
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: go.opentelemetry.io/otel
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: go.opentelemetry.io/otel/metric
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: go.opentelemetry.io/otel/trace
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: golang.org/x/net
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: golang.org/x/oauth2
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: golang.org/x/sys
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: golang.org/x/term
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: golang.org/x/text
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: golang.org/x/time
  dependency-type: indirect
  update-type: version-update:semver-minor
  dependency-group: github-dependencies
- dependency-name: google.golang.org/genproto/googleapis/rpc
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
…/go_modules/github-dependencies-24b967fb58

Bump the github-dependencies group across 1 directory with 17 updates
…hot-controller

Previously, the csi-snapshotter was responsible for creating individual
VolumeSnapshots and VolumeSnapshotContents for each member when
dynamically provisioning a VolumeGroupSnapshot.

This commit relocates this logic to the snapshot-controller, bringing
all resource creation processes under a single authority.
this commit updates csi spec version to
include latest changes for volume group
snapshot

Signed-off-by: yati1998 <ypadia@redhat.com>
Centralize VolumeGroupSnapshot members resource creation in the snapshot-controller
…oupSnapshotRef_check

Remove volumeGroupSnapshotRef immutable validation rule
This patch sets the `spec.persistentVolumeClaimName` field for
volume snapshots that are member of a dynamically provisioned volume
group snapshot, like a dynamically provisioned volume snapshot would do.

The volume snapshot logic has been improved to skip the creation of
relative snapshot as it has already been created by the group snapshot.
Set PVC name on VolumeGroupSnapshot members
Add secrets for Get VolumeGroupSnapshot
this commit includes feature gate method
to enable the volumeGroupSnapshot

Signed-off-by: yati1998 <ypadia@redhat.com>
…TODO

Pass context on in GroupSnapshot sync functions
…esnapshotcontentlist

Remove PVVolumeSnapshotContentList field from the VolumeGroupSnapshotContentStatus API
@gnufied gnufied force-pushed the update-openshift-master-with-upstream-master branch from c6b5a7d to 6ff7745 Compare December 10, 2024 21:57
@gnufied gnufied changed the title WIP: STOR-2135: Bring latest changes for snapshotter STOR-2135: Bring latest changes for snapshotter Dec 10, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2024
@gnufied
Copy link
Member Author

gnufied commented Dec 10, 2024

The failing e2e is because we will need openshift/cluster-csi-snapshot-controller-operator#219 for removal of webhook deployment before all of that stuff can start passing.

@jsafrane
Copy link

lgtm-ish, waiting for openshift/cluster-csi-snapshot-controller-operator#219

@duanwei33
Copy link

duanwei33 commented Dec 17, 2024

QE verified the volumesnapshot/volumesgroupnapshot feature with openshift/csi-external-snapshotter#166,openshift/cluster-csi-snapshot-controller-operator#219,openshift/api#2106,openshift/kubernetes#2155, all look okay.

@duanwei33
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 17, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 17, 2024

@gnufied: This pull request references STOR-2135 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

To be used with openshift/cluster-csi-snapshot-controller-operator#219

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@duanwei33
Copy link

/retest

@Phaow
Copy link

Phaow commented Dec 17, 2024

/retest-required

@jsafrane
Copy link

jsafrane commented Dec 17, 2024

/retest-required
build cluster ran out of CPU

@jsafrane
Copy link

/test help
looking for a tech preview job

Copy link

openshift-ci bot commented Dec 17, 2024

@jsafrane: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws-csi
/test e2e-gcp-csi
/test e2e-vsphere
/test e2e-vsphere-csi
/test images
/test unit
/test verify-commits
/test verify-deps

The following commands are available to trigger optional jobs:

/test okd-scos-e2e-aws-ovn
/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-csi-external-snapshotter-master-e2e-aws-csi
pull-ci-openshift-csi-external-snapshotter-master-e2e-gcp-csi
pull-ci-openshift-csi-external-snapshotter-master-e2e-vsphere
pull-ci-openshift-csi-external-snapshotter-master-e2e-vsphere-csi
pull-ci-openshift-csi-external-snapshotter-master-images
pull-ci-openshift-csi-external-snapshotter-master-okd-scos-e2e-aws-ovn
pull-ci-openshift-csi-external-snapshotter-master-unit
pull-ci-openshift-csi-external-snapshotter-master-verify-commits
pull-ci-openshift-csi-external-snapshotter-master-verify-deps

In response to this:

/test help
looking for a tech preview job

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jsafrane
Copy link

/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview

Copy link

openshift-ci bot commented Dec 17, 2024

@jsafrane: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cf5b5e30-bc4d-11ef-8df4-80ec9045fac7-0

@Phaow
Copy link

Phaow commented Dec 17, 2024

/test e2e-gcp-csi

@jsafrane
Copy link

tech preview job passed
/lgtm
/retest-required
(GCP builders have some issues...

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
@Phaow
Copy link

Phaow commented Dec 17, 2024

/retest-required

@gnufied
Copy link
Member Author

gnufied commented Dec 17, 2024

/override pull-ci-openshift-csi-external-snapshotter-master-e2e-gcp-csi

Copy link

openshift-ci bot commented Dec 17, 2024

@gnufied: Overrode contexts on behalf of gnufied: ci/prow/e2e-gcp-csi

In response to this:

/override pull-ci-openshift-csi-external-snapshotter-master-e2e-gcp-csi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Dec 17, 2024

@gnufied: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 6ff7745 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1fc6ee1 into openshift:master Dec 17, 2024
9 of 10 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-csi-snapshot-controller
This PR has been included in build ose-csi-snapshot-controller-container-v4.19.0-202412171706.p0.g1fc6ee1.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: csi-snapshot-validation-webhook
This PR has been included in build ose-csi-snapshot-validation-webhook-container-v4.19.0-202412171706.p0.g1fc6ee1.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-csi-external-snapshotter
This PR has been included in build ose-csi-external-snapshotter-container-v4.19.0-202412171706.p0.g1fc6ee1.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.