Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-19521: Add the supported OLM operators names in the swagger file #7196

Merged
merged 1 commit into from
Jan 23, 2025
Merged

MGMT-19521: Add the supported OLM operators names in the swagger file #7196

merged 1 commit into from
Jan 23, 2025

Conversation

rivkyrizel
Copy link
Contributor

This PR addresses the need to update the Swagger file with the supported OLM operators' names, improving the clarity of API documentation.

Since this change modifies only the swagger.yaml file, no automated tests are necessary.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

/cc @gamli75 @eliorerz

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 16, 2025
@openshift-ci openshift-ci bot requested review from eliorerz and gamli75 January 16, 2025 15:58
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 16, 2025 •
edited by openshift-ci bot
Loading

@rivkyrizel: This pull request references MGMT-19521 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

This PR addresses the need to update the Swagger file with the supported OLM operators' names, improving the clarity of API documentation.

Since this change modifies only the swagger.yaml file, no automated tests are necessary.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

/cc @gamli75 @eliorerz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. api-review Categorizes an issue or PR as actively needing an API review. labels Jan 16, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.32%. Comparing base (7f77988) to head (dc683fe).
Report is 15 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7196      +/-   ##
==========================================
+ Coverage   67.70%   69.32%   +1.62%     
==========================================
  Files         296      298       +2     
  Lines       40459    43244    +2785     
==========================================
+ Hits        27391    29981    +2590     
- Misses      10607    10675      +68     
- Partials     2461     2588     +127

see 42 files with indirect coverage changes

@paul-maidment
Copy link
Contributor

/test edge-e2e-ai-operator-ztp

@paul-maidment
Copy link
Contributor

/test edge-subsystem-kubeapi-aws

@paul-maidment
Copy link
Contributor

/test okd-scos-e2e-aws-ovn

@paul-maidment
Copy link
Contributor

/test edge-e2e-ai-operator-ztp

@danmanor
Copy link
Contributor

/test mce-images

@danmanor
Copy link
Contributor

/retest

@danmanor
Copy link
Contributor

@rivkyrizel Run skipper make generate and push again

@rivkyrizel
Copy link
Contributor Author

rivkyrizel commented Jan 20, 2025 •
edited
Loading

/test edge-e2e-ai-operator-disconnected-capi

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 20, 2025

@rivkyrizel: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-agent-compact-ipv4

/test edge-assisted-operator-catalog-publish-verify

/test edge-ci-index

/test edge-e2e-ai-operator-ztp

/test edge-e2e-ai-operator-ztp-sno-day2-workers

/test edge-e2e-ai-operator-ztp-sno-day2-workers-late-binding

/test edge-e2e-metal-assisted-4-12

/test edge-e2e-metal-assisted-4-18

/test edge-e2e-metal-assisted-4-control-planes-4-18

/test edge-e2e-metal-assisted-5-control-planes-4-18

/test edge-e2e-metal-assisted-cnv-4-16

/test edge-e2e-metal-assisted-cnv-4-17

/test edge-e2e-metal-assisted-lvm-4-18

/test edge-e2e-metal-assisted-mtv-4-17

/test edge-e2e-metal-assisted-odf-4-16

/test edge-e2e-metal-assisted-odf-4-17

/test edge-images

/test edge-lint

/test edge-operator-publish-verify

/test edge-subsystem-aws

/test edge-subsystem-kubeapi-aws

/test edge-unit-test

/test edge-verify-generated-code

/test images

/test mce-images

The following commands are available to trigger optional jobs:

/test e2e-agent-4control-ipv4

/test e2e-agent-5control-ipv4

/test e2e-agent-ha-dualstack

/test e2e-agent-sno-ipv6

/test edge-e2e-ai-operator-disconnected-capi

/test edge-e2e-ai-operator-ztp-3masters

/test edge-e2e-ai-operator-ztp-4masters

/test edge-e2e-ai-operator-ztp-5masters

/test edge-e2e-ai-operator-ztp-capi

/test edge-e2e-ai-operator-ztp-compact-day2-masters

/test edge-e2e-ai-operator-ztp-compact-day2-workers

/test edge-e2e-ai-operator-ztp-disconnected

/test edge-e2e-ai-operator-ztp-hypershift-zero-nodes

/test edge-e2e-ai-operator-ztp-multiarch-3masters-ocp

/test edge-e2e-ai-operator-ztp-multiarch-sno-ocp

/test edge-e2e-ai-operator-ztp-node-labels

/test edge-e2e-ai-operator-ztp-remove-node

/test edge-e2e-ai-operator-ztp-sno-day2-masters

/test edge-e2e-ai-operator-ztp-sno-day2-workers-ignitionoverride

/test edge-e2e-metal-assisted-4-13

/test edge-e2e-metal-assisted-4-14

/test edge-e2e-metal-assisted-4-15

/test edge-e2e-metal-assisted-4-16

/test edge-e2e-metal-assisted-4-17

/test edge-e2e-metal-assisted-4-masters-none-4-18

/test edge-e2e-metal-assisted-bond-4-14

/test edge-e2e-metal-assisted-bond-4-18

/test edge-e2e-metal-assisted-day2-4-18

/test edge-e2e-metal-assisted-day2-arm-workers-4-18

/test edge-e2e-metal-assisted-day2-sno-4-18

/test edge-e2e-metal-assisted-external-4-14

/test edge-e2e-metal-assisted-external-4-18

/test edge-e2e-metal-assisted-ipv4v6-4-18

/test edge-e2e-metal-assisted-ipv6-4-18

/test edge-e2e-metal-assisted-kube-api-late-binding-sno-4-18

/test edge-e2e-metal-assisted-kube-api-late-unbinding-sno-4-18

/test edge-e2e-metal-assisted-kube-api-net-suite-4-18

/test edge-e2e-metal-assisted-kube-api-umlb-4-18

/test edge-e2e-metal-assisted-mce-4-16

/test edge-e2e-metal-assisted-mce-sno-4-16

/test edge-e2e-metal-assisted-metallb-4-18

/test edge-e2e-metal-assisted-none-4-18

/test edge-e2e-metal-assisted-onprem-4-18

/test edge-e2e-metal-assisted-osc-4-18

/test edge-e2e-metal-assisted-osc-sno-4-18

/test edge-e2e-metal-assisted-sno-4-18

/test edge-e2e-metal-assisted-static-ip-suite-4-14

/test edge-e2e-metal-assisted-static-ip-suite-4-18

/test edge-e2e-metal-assisted-tang-4-18

/test edge-e2e-metal-assisted-tpmv2-4-18

/test edge-e2e-metal-assisted-umlb-4-18

/test edge-e2e-metal-assisted-upgrade-agent-4-18

/test edge-e2e-nutanix-assisted-2workers-4-18

/test edge-e2e-nutanix-assisted-4-14

/test edge-e2e-nutanix-assisted-4-18

/test edge-e2e-oci-assisted-4-14

/test edge-e2e-oci-assisted-4-18

/test edge-e2e-oci-assisted-iscsi-4-18

/test edge-e2e-vsphere-assisted-4-14

/test edge-e2e-vsphere-assisted-4-15

/test edge-e2e-vsphere-assisted-4-16

/test edge-e2e-vsphere-assisted-4-18

/test edge-e2e-vsphere-assisted-umn-4-18

/test okd-scos-e2e-aws-ovn

/test okd-scos-images

/test push-pr-image

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-assisted-service-master-e2e-agent-compact-ipv4

pull-ci-openshift-assisted-service-master-edge-ci-index

pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-disconnected-capi

pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp

pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-capi

pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-4-18

pull-ci-openshift-assisted-service-master-edge-images

pull-ci-openshift-assisted-service-master-edge-lint

pull-ci-openshift-assisted-service-master-edge-subsystem-aws

pull-ci-openshift-assisted-service-master-edge-subsystem-kubeapi-aws

pull-ci-openshift-assisted-service-master-edge-unit-test

pull-ci-openshift-assisted-service-master-edge-verify-generated-code

pull-ci-openshift-assisted-service-master-images

pull-ci-openshift-assisted-service-master-mce-images

pull-ci-openshift-assisted-service-master-okd-scos-e2e-aws-ovn

In response to this:

/test ci/prow/edge-e2e-ai-operator-disconnected-capi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rivkyrizel
Copy link
Contributor Author

/test edge-e2e-ai-operator-disconnected-capi

@danmanor
Copy link
Contributor

danmanor commented Jan 21, 2025 •
edited
Loading

@rivkyrizel Disocnnected capi job is broken at the moment (https://prow.ci.openshift.org/job-history/gs/test-platform-results/pr-logs/directory/pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-disconnected-capi), I am overriding it

@danmanor
Copy link
Contributor

/override ci/prow/edge-e2e-ai-operator-disconnected-capi

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 21, 2025

@danmanor: Overrode contexts on behalf of danmanor: ci/prow/edge-e2e-ai-operator-disconnected-capi

In response to this:

/override ci/prow/edge-e2e-ai-operator-disconnected-capi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

eliorerz
eliorerz requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@eliorerz eliorerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
Just a quick note: please squash the redundant commits into one to keep the history clean. Let me know if you need help with it!

@rivkyrizel
MGMT-19521: Add the supported OLM operators names
dc683fe 
MGMT-19521: Add the supported OLM operators names

MGMT-19521: Add the supported OLM operators names

MGMT-19521: Add the supported OLM operators names
@rivkyrizel
Copy link
Contributor Author

/test okd-scos-e2e-aws-ovn

@rivkyrizel rivkyrizel requested a review from eliorerz January 22, 2025 12:20
@rivkyrizel
Copy link
Contributor Author

/test okd-scos-e2e-aws-ovn

@rivkyrizel
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, rivkyrizel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 23, 2025

@rivkyrizel: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit dd3c75d into openshift:master Jan 23, 2025
19 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-agent-installer-api-server
This PR has been included in build ose-agent-installer-api-server-container-v4.19.0-202501240307.p0.gdd3c75d.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gamli75 gamli75 gamli75 approved these changes

@eliorerz eliorerz Awaiting requested review from eliorerz

Assignees

@eliorerz eliorerz

@gamli75 gamli75

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rivkyrizel @openshift-ci-robot @paul-maidment @danmanor @openshift-bot @eliorerz @gamli75