Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-ocm-2.5] Bug 2081609: Add the ability to override image-service image when deploying the assisted-image-service #3758

Merged
merged 1 commit into from
May 4, 2022
Merged

[release-ocm-2.5] Bug 2081609: Add the ability to override image-service image when deploying the assisted-image-service #3758

merged 1 commit into from
May 4, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #3737

/assign eliorerz

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 3, 2022
Merged
16 tasks
@eliorerz eliorerz mentioned this pull request May 3, 2022
Merged
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 3, 2022
@openshift-ci openshift-ci bot requested review from empovit and osherdp May 3, 2022 15:55
@openshift-ci
Copy link

openshift-ci bot commented May 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eliorerz, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 3, 2022
@codecov
Copy link

codecov bot commented May 3, 2022 •
edited
Loading

Codecov Report

Merging #3758 (0356f7e) into release-ocm-2.5 (0356f7e) will not change coverage.
The diff coverage is n/a.

❗ Current head 0356f7e differs from pull request most recent head 1a2bbb9. Consider uploading reports for the commit 1a2bbb9 to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##           release-ocm-2.5    #3758   +/-   ##
================================================
  Coverage            66.87%   66.87%           
================================================
  Files                  172      172           
  Lines                24554    24554           
================================================
  Hits                 16421    16421           
  Misses                6529     6529           
  Partials              1604     1604

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@eliorerz
Copy link
Contributor

eliorerz commented May 3, 2022

/override ci/prow/e2e-ai-operator-ztp-ipv4v6-sno-ocp-49

@openshift-ci
Copy link

openshift-ci bot commented May 3, 2022

@eliorerz: Overrode contexts on behalf of eliorerz: ci/prow/e2e-ai-operator-ztp-ipv4v6-sno-ocp-49

In response to this:

/override ci/prow/e2e-ai-operator-ztp-ipv4v6-sno-ocp-49

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented May 3, 2022

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ai-operator-ztp-ipv4v6-sno-ocp-49 1a2bbb9 link false /test e2e-ai-operator-ztp-ipv4v6-sno-ocp-49

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@carbonin
Copy link
Member

carbonin commented May 3, 2022

This is only a change to our CI tools.

@osherdp @filanov do we really need a BZ for this or can we just add the label manually to get this in?

@vrutkovs
Copy link
Member

vrutkovs commented May 4, 2022

/retitle [release-ocm-2.5] Bug 2081609: Add the ability to override image-service image when deploying the assisted-image-service

@openshift-ci openshift-ci bot changed the title [release-ocm-2.5] NO-ISSUE - Add the ability to override image-service image when deploying the assisted-image-service [release-ocm-2.5] Bug 2081609: Add the ability to override image-service image when deploying the assisted-image-service May 4, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 4, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 4, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2081609, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (rhacm-2.5) matches configured target release for branch (rhacm-2.5)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2081608 is in the state CLOSED (CURRENTRELEASE), which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2081608 targets the "rhacm-2.6" release, which is one of the valid target releases: rhacm-2.6
  • bug has dependents

In response to this:

[release-ocm-2.5] Bug 2081609: Add the ability to override image-service image when deploying the assisted-image-service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 36e13cf into openshift:release-ocm-2.5 May 4, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 4, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2081609 has been moved to the MODIFIED state.

In response to this:

[release-ocm-2.5] Bug 2081609: Add the ability to override image-service image when deploying the assisted-image-service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliorerz eliorerz eliorerz approved these changes

@empovit empovit Awaiting requested review from empovit

@osherdp osherdp Awaiting requested review from osherdp

Assignees

@eliorerz eliorerz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@openshift-cherrypick-robot @openshift-bot @eliorerz @carbonin @vrutkovs @openshift-merge-robot