Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component types export #957

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Component types export #957

wants to merge 2 commits into from
+68 −4

Conversation

xfournet
Copy link

@xfournet xfournet commented Jan 9, 2025 •
edited
Loading

Description

Export the TS type in api/_types to Types

Issues Resolved

Closes #955

Check List

  • New functionality includes testing -> I didn't see tests for generator
  • All tests pass
  • Linter check was successfull - yarn run lint doesn't show any errors
  • Commits are signed per the DCO using --signoff
  • Changelog was updated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@xfournet
Windows support
075e3c7 
Signed-off-by: Xavier Fournet <461943+xfournet@users.noreply.github.com>
@xfournet
Generate api/_types/index.d.ts (opensearch-project#955)
61f27a6 
Signed-off-by: Xavier Fournet <461943+xfournet@users.noreply.github.com>
@xfournet xfournet mentioned this pull request Jan 9, 2025
Open
@nhtruong
Copy link
Collaborator

nhtruong commented Jan 9, 2025 •
edited
Loading

Looks great! There's a type error in CI tho. You will have to run the generator and commit the changes from the generator as well.

I'm manually triggering the api_gen workflow so that your PR will only contain the changes from the new type module. Don't forget to rebase.

@xfournet
Copy link
Author

xfournet commented Jan 9, 2025

Looks great! There's a type error in CI tho. You will have to run the generator and commit the changes from the generator as well.

I'm manually triggering the api_gen workflow so that your PR will only contain the changes from the new type module. Don't forget to rebase.

The type error is because i didn't commit the ouput of the generator so far :) you should trigger the api_gen workflow first ?

@xfournet
Copy link
Author

xfournet commented Jan 9, 2025

I get a lot of unrelated diff (same result without my change).
Do I need to use a precise version of the opensearch-openapi.yaml or use the latest anyway ? in the later case i will separate the 'update to latest spec' commit from the others

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@nhtruong nhtruong Awaiting requested review from nhtruong nhtruong is a code owner

@harshavamsi harshavamsi Awaiting requested review from harshavamsi harshavamsi is a code owner

@timursaurus timursaurus Awaiting requested review from timursaurus timursaurus is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@xfournet @nhtruong