Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception with unknown residues #322

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

peastman
Copy link
Member

@peastman peastman commented Jan 6, 2025

Fixes #321. The error happened in a file containing the residue ID UNL (unknown ligand). The CCD contains an entry for it, but it's a minimal file with no atoms. That led to an exception.

@peastman peastman merged commit 29fcf15 into openmm:master Jan 6, 2025
3 checks passed
@peastman peastman deleted the unl branch January 6, 2025 17:26
@davidlmobley
Copy link

Thanks. How soon could we expect this to be in a release? (My course conda/mamba installs openmm, so I need to know if this will be in a release before I get to the lecture, which is probably mid-February.)

@peastman
Copy link
Member Author

peastman commented Jan 6, 2025

I think we can do that. Let's wait a little longer to give time for more bugs to come up. If I haven't created a new release by the end of the month, remind me and I'll do it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDBFixer fails to solvate due to a None return, without a handled exception
2 participants