-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve espaloma
Support
#336
Comments
Espaloma 0.3.x is supported, we have run simulations using it for both protein and small molecules. That said, the way to use it is probably not that easy to accomplish, we should make this more streamlined. We had specific GHA workflows to test the espaloma support but I don't know why or when these were removed. Sounds like we should get these back. |
I'm curious the use cases of Espaloma with this package vs. just using Espaloma's API directly to generate parameters (in the form of an
The current architecture of building something on top of |
They were just consolidated into a single CI file, I said "improve" espaloma support since for the end-user it looks like we only support once espaloma ff, I will update the issue instead to update what we consider the "default" espaloma version (just like we updated the default openff version) openmmforcefields/openmmforcefields/generators/template_generators.py Lines 1801 to 1807 in f943979
|
Ah I see, what I saw is that the espaloma tests are being skipped. I set these tests to be run with the |
@mattwthompson This is a good point to raise. As far as I can tell, we do want to maintain the possibility of using Espaloma only for specific portions of the topology (be it only the small molecule, or a mutant residue, a cofactor, etc.). However, I agree that the current approach is very cumbersome and hard to maintain in the longer term. |
We should update the default espaloma ff to
espaloma-0.3.2.pt
The text was updated successfully, but these errors were encountered: