Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add users wanglong&lbdj #118

Merged
merged 1 commit into from
Dec 18, 2023
Merged

add users wanglong&lbdj #118

merged 1 commit into from
Dec 18, 2023

Conversation

chrisliu1995
Copy link
Member

No description provided.

@chrisliu1995
add users wanglong&lbdj
574086d 
Signed-off-by: ChrisLiu <chrisliu1995@163.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (250bd86) 32.63% compared to head (574086d) 32.63%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   32.63%   32.63%           
=======================================
  Files          23       23           
  Lines        3144     3144           
=======================================
  Hits         1026     1026           
  Misses       2065     2065           
  Partials       53       53
Flag Coverage Δ
unittests 32.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ringtail
ringtail approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@ringtail ringtail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ringtail
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ringtail ringtail merged commit 1181b22 into openkruise:master Dec 18, 2023
5 of 6 checks passed
@chrisliu1995 chrisliu1995 deleted the user branch May 9, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ringtail ringtail ringtail approved these changes

@furykerry furykerry Awaiting requested review from furykerry

@zmberg zmberg Awaiting requested review from zmberg

Assignees

@ringtail ringtail

Labels
lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisliu1995 @codecov-commenter @kruise-bot @ringtail