Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: fixed console warnings #1990

Merged
merged 1 commit into from
Sep 24, 2024
Merged

frontend: fixed console warnings #1990

merged 1 commit into from
Sep 24, 2024
+18 −16

Conversation

SamuelPull
Copy link
Collaborator

@SamuelPull SamuelPull commented Sep 23, 2024 •
edited
Loading

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

How to test

  1. Rebuild frontend image and run TB
  2. There should be no warning nor error concerning findDOMNode, property f, button outside span

Closes #1989

@github-actions GitHub Actions
Copy link

Warnings
⚠️ No CHANGELOG added.
⚠️ There were changes in the frontend, but no E2E-test was added or modified!

Generated by 🚫 dangerJS against dc54ee6

@openkfwCI
Copy link

openkfwCI commented Sep 23, 2024 •
edited
Loading

NotesTime
✅Note for Reviewer: E2E tests on pipeline 60405 on remote server succeededMon, 23 Sep 2024 14:18:44 +0000

Generated by E2E-Test

@SamuelPull SamuelPull marked this pull request as ready for review September 24, 2024 06:22
@SamuelPull SamuelPull merged commit 496f8c7 into main Sep 24, 2024
30 checks passed
@SamuelPull SamuelPull deleted the 1989-fix-console-warnings branch September 24, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

frontend: Fix console warnings
2 participants
@SamuelPull @openkfwCI