api: create and read snapshots with log

openkfw · Dec 11, 2023 · 2ce8167 · 2ce8167
1 parent 2a4b983
commit 2ce8167
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/api/src/service/cache_snapshot.ts b/api/src/service/cache_snapshot.ts
@@ -172,7 +172,7 @@ export async function getLatestSnapshot(
   items = items.slice(snapshotIndex + 1);
   const parsedEvents = parseBusinessEvents(items, streamName);
   const businessEvents = parsedEvents.filter(Result.isOk);
-  const sourcedData = sourceFromSnapshot(ctx, businessEvents, false, data);
+  const sourcedData = sourceFromSnapshot(ctx, businessEvents, true, data);
 
   // if there are reordering events, apply it
   if (lastOrderingEventItem && eventType === SUBPROJECT_SNAPSHOT_EVENT_KEY) {
@@ -240,7 +240,7 @@ export async function publishSnapshot(
   const parsedEvents = parseBusinessEvents(items, streamName);
   const businessEvents = parsedEvents.filter(Result.isOk);
 
-  const sourcedData = sourceFromSnapshot(ctx, businessEvents, false, data);
+  const sourcedData = sourceFromSnapshot(ctx, businessEvents, true, data);
   if (ordering && eventType === SUBPROJECT_SNAPSHOT_EVENT_KEY) {
     if (Result.isOk(sourcedData)) {
       sourcedData.workflowitemOrdering = ordering;

diff --git a/api/src/service/domain/workflow/workflowitem_ordering.ts b/api/src/service/domain/workflow/workflowitem_ordering.ts
@@ -1,5 +1,6 @@
 import { AssertionError } from "assert";
 import * as Workflowitem from "./workflowitem";
+import logger from "../../../lib/logger";
 
 export type WorkflowitemOrdering = Workflowitem.Id[];
 
@@ -73,7 +74,11 @@ function closedAt(item: Workflowitem.ScrubbedWorkflowitem): string | AssertionEr
   const traceEvent = item.log.find((e) => e.businessEvent.type === "workflowitem_closed");
 
   if (traceEvent === undefined || traceEvent.businessEvent.type !== "workflowitem_closed") {
-    return new AssertionError({ message: `Expected close event for workflowitem ${item.id}` });
+    const error = new AssertionError({
+      message: `Expected close event for workflowitem ${item.id}`,
+    });
+    logger.error(error, error.message);
+    return error;
   }
   const closeEvent = traceEvent.businessEvent;