remove golint errors (rs#187)

openk8sai · Oct 4, 2019 · 33a4561 · 33a4561
1 parent 0659953
commit 33a4561
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/journald/journald.go b/journald/journald.go
@@ -68,7 +68,7 @@ func levelToJPrio(zLevel string) journal.Priority {
 
 func (w journalWriter) Write(p []byte) (n int, err error) {
 	if !journal.Enabled() {
-		err = fmt.Errorf("Cannot connect to journalD!!")
+		err = fmt.Errorf("cannot connect to journalD")
 		return
 	}
 	var event map[string]interface{}

diff --git a/log.go b/log.go
@@ -303,9 +303,9 @@ func (l *Logger) Error() *Event {
 func (l *Logger) Err(err error) *Event {
 	if err != nil {
 		return l.Error().Err(err)
-	} else {
-		return l.Info()
 	}
+
+	return l.Info()
 }
 
 // Fatal starts a new message with fatal level. The os.Exit(1) function

diff --git a/log_test.go b/log_test.go
@@ -696,9 +696,9 @@ func TestCallerMarshalFunc(t *testing.T) {
 		parts := strings.Split(file, "/")
 		if len(parts) > 1 {
 			return strings.Join(parts[len(parts)-2:], "/") + ":" + strconv.Itoa(line)
-		} else {
-			return file + ":" + strconv.Itoa(line)
 		}
+
+		return file + ":" + strconv.Itoa(line)
 	}
 	_, file, line, _ = runtime.Caller(0)
 	caller = CallerMarshalFunc(file, line+2)