Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8340494: Open some dialog awt tests 4 #21479

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alisenchung
Copy link
Contributor

@alisenchung alisenchung commented Oct 11, 2024

Fifth set of swing test to open for fall 2024 test sprint


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21479/head:pull/21479
$ git checkout pull/21479

Update a local copy of the PR:
$ git checkout pull/21479
$ git pull https://git.openjdk.org/jdk.git pull/21479/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21479

View PR using the GUI difftool:
$ git pr show -t 21479

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21479.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2024

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 11, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 11, 2024
@openjdk
Copy link

openjdk bot commented Oct 11, 2024

@alisenchung The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 11, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 11, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant