8341903: Implementation of Scoped Values (Fourth Preview) #21456
Conversation
|
👋 Welcome back aph! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@theRealAph The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
openjdk
bot
added
security
Webrevs
|
|
@theRealAph The update to src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java needs to be included too. Also test/jdk/jdk/internal/misc/ThreadFlock/WithScopedValue.java is updated in the loom repo, need to include that change too. |
| * try (var scope = new StructuredTaskScope<String>()) { | ||
| * ScopedValue.where(NAME, "duke").run(() -> { | ||
| * // @link substring="open" target="StructuredTaskScope#open()" : | ||
| * try (var scope = StructuredTaskScope.open()) { | ||
| * |
There was a problem hiding this comment.
You'll need to revert this line as that is the updated STS API so will be update with its next JEP.
There was a problem hiding this comment.
Make sure to run jdk:tier1 and jdk:tier2 as that will run the tests that use this API.
|
The one line change in /label remove security |
|
@wangweij |
|
/csr |
|
@AlanBateman has indicated that a compatibility and specification (CSR) request is needed for this pull request. @theRealAph please create a CSR request for issue JDK-8341903 with the correct fix version. This pull request cannot be integrated until the CSR request is approved. |
|
/jep jep-487 |
The fourth preview of scoped values.
Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21456/head:pull/21456$ git checkout pull/21456Update a local copy of the PR:
$ git checkout pull/21456$ git pull https://git.openjdk.org/jdk.git pull/21456/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21456View PR using the GUI difftool:
$ git pr show -t 21456Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21456.diff
Webrev
Link to Webrev Comment