Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode #21401

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode #21401

wants to merge 12 commits into from

Conversation

xmas92
Copy link
Member

@xmas92 xmas92 commented Oct 8, 2024 •
edited by openjdk bot
Loading

This is the implementation task for JEP 490: ZGC: Remove the Non-Generational Mode. See the JEP for details. JDK-8335850

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a JEP request to be targeted
  • Change must be properly reviewed (3 reviews required, with at least 1 Reviewer, 2 Authors)
  • Change requires CSR request JDK-8341693 to be approved

Issues

  • JDK-8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode (Sub-task - P4)
  • JDK-8335850: JEP 490: ZGC: Remove the Non-Generational Mode (JEP)
  • JDK-8341693: Implement JEP 490: ZGC: Remove the Non-Generational Mode (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21401/head:pull/21401
$ git checkout pull/21401

Update a local copy of the PR:
$ git checkout pull/21401
$ git pull https://git.openjdk.org/jdk.git pull/21401/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21401

View PR using the GUI difftool:
$ git pr show -t 21401

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21401.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 8, 2024

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 8, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Oct 8, 2024
@openjdk
Copy link

openjdk bot commented Oct 8, 2024

@xmas92 The following labels will be automatically applied to this pull request:

  • build
  • client
  • core-libs
  • graal
  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org build build-dev@openjdk.org client client-libs-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Oct 8, 2024
@xmas92 xmas92 marked this pull request as ready for review October 9, 2024 11:46
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 9, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 9, 2024 •
edited
Loading

Webrevs

magicus
magicus approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@magicus magicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build changes look good.

Are you on a direct track towards winning over the title of Dr Deprecator? ;-)

/reviewers 3

@stefank
Copy link
Member

stefank commented Oct 9, 2024

Looks good to me!

@openjdk
Copy link

openjdk bot commented Oct 9, 2024

@magicus
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 3 (with at least 1 Reviewer, 2 Authors).

@liach
Copy link
Member

liach commented Oct 9, 2024

/jep jep-490

@openjdk
Copy link

openjdk bot commented Oct 9, 2024

@liach
This pull request will not be integrated until the JEP-490 has been targeted.

@openjdk openjdk bot added the jep label Oct 9, 2024
stefank
stefank reviewed Oct 9, 2024
View reviewed changes
src/hotspot/share/runtime/arguments.cpp
@@ -521,7 +520,7 @@ static SpecialFlag const special_jvm_flags[] = {
// -------------- Obsolete Flags - sorted by expired_in --------------

{ "MetaspaceReclaimPolicy", JDK_Version::undefined(), JDK_Version::jdk(21), JDK_Version::undefined() },

{ "ZGenerational", JDK_Version::jdk(23), JDK_Version::jdk(24), JDK_Version::undefined() },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR: This line depends on what version the JEP gets targeted to.

fisk
fisk approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@fisk fisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

prrace
prrace approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the 2D/AWT test changes are fine. I've not looked at anything else.

@xmas92
Merge tag 'jdk-24+19' into JDK-8341692
e58b4c5 
Added tag jdk-24+19 for changeset e7c5bf4
plummercj
plummercj approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@plummercj plummercj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The serviceability related changes look good. I suppose the 6 or so SA bugs filed against the non-generational ZGC can be closed out. I have a note to myself to go through them and close if appropriate. We have JDK-8307393 filed for the lack of SA support for generational ZGC, and that is probably the only SA ZGC related issue we need to keep around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefank stefank stefank left review comments

@fisk fisk fisk approved these changes

@magicus magicus magicus approved these changes

@prrace prrace prrace approved these changes

@plummercj plummercj plummercj approved these changes

Assignees
No one assigned
Labels
build build-dev@openjdk.org client client-libs-dev@openjdk.org core-libs core-libs-dev@openjdk.org csr Pull request needs approved CSR before integration graal graal-dev@openjdk.org hotspot hotspot-dev@openjdk.org jep rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@xmas92 @stefank @liach @fisk @magicus @prrace @plummercj