Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test branch #205

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Test branch #205

merged 3 commits into from
Jan 7, 2025

Conversation

pellicceama
Copy link
Collaborator

@pellicceama pellicceama commented Jan 7, 2025

Important

Fixes version tag handling and improves changelog formatting in release-workflow.yml.

  • Version Calculation:
    • Fix handling of version tags by removing 'v' prefix in release-workflow.yml.
    • Corrects version increment logic in Calculate new version step.
  • Changelog Generation:
    • Fixes formatting in Generate changelog step by quoting ${{ env.latest_tag }}.
    • Improves PR data formatting in Format PR data step using jq.
  • Misc:
    • Minor improvements in Extract PR titles and important lines step for better parsing.

This description was created by Ellipsis for cf42e7e. It will automatically update as commits are pushed.

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
openint ❌ Failed (Inspect) Jan 7, 2025 1:07pm

@pellicceama pellicceama merged commit 92dc53a into main Jan 7, 2025
1 of 2 checks passed
@pellicceama pellicceama deleted the test-branch branch January 7, 2025 13:05
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to cf42e7e in 24 seconds

More details
  • Looked at 31 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .github/workflows/release-workflow.yml:39
  • Draft comment:
    Incorrect syntax for accessing environment variables. Use ${{ env.LATEST_TAG }} instead of ${env.latest_tag}. This issue also appears on lines 60 and 64.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_ltlWOd0fPvLgt47h


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant