Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test release5 #203

Merged
merged 1 commit into from
Jan 7, 2025
Merged

test release5 #203

merged 1 commit into from
Jan 7, 2025

Conversation

pellicceama
Copy link
Collaborator

@pellicceama pellicceama commented Jan 7, 2025

Important

Add quotes around ${{ env.latest_tag }} in release-workflow.yml to handle special characters in tags.

  • Workflow Script:
    • Add quotes around ${{ env.latest_tag }} in git log command in release-workflow.yml to handle special characters or spaces in tags.

This description was created by Ellipsis for a451205. It will automatically update as commits are pushed.

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
openint ❌ Failed (Inspect) Jan 7, 2025 0:56am

@pellicceama pellicceama merged commit 0256d59 into main Jan 7, 2025
1 of 2 checks passed
@pellicceama pellicceama deleted the test-branch branch January 7, 2025 12:55
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to a451205 in 8 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .github/workflows/release-workflow.yml:51
  • Draft comment:
    Enclosing variables in double quotes is a good practice to prevent word splitting and globbing issues. This change improves the robustness of the script.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change in the PR is a minor improvement for readability and consistency.

Workflow ID: wflow_Akn08me9K0MGWVSI


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant