libcanberra: Fix sound not playing on Colibri iMX8X #894
+41
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Canberra does not specify a buffer size, which leads to ALSA rejecting the settings. By specfiying a buffer time of 500ms and a period time with a fourth of that, an appropriate buffer size should be able to be calculated for all setups.
kraj
requested changes
Nov 20, 2024
|
|
||
| This code sets the buffer time to 500ms and the period time to a fourth of that, | ||
| or whatever is nearest to that. | ||
| --- |
There was a problem hiding this comment.
Please add Upstream-Status field to patch. This is a required field these days.
stdio: ERROR: libcanberra-0.30-r0 do_patch: QA Issue: Missing Upstream-Status in patch
stdio: ERROR: libcanberra-0.30-r0 do_patch: Fatal QA errors were found, failing task.
There was a problem hiding this comment.
Would Upstream-Status: Pending be appropriate?
The mailing list archive is defunct and no updates to the project have been made on Upstream in 12 years.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Canberra does not specify a buffer size, which leads to ALSA rejecting the settings. By specfiying a buffer time of 500ms and a period time with a fourth of that, an appropriate buffer size should be able to be calculated for all setups.