-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Washington transforms and validators #219
Comments
Well the first issue I ran into is the mongoengine query set can't find any data -- even Maryland's transform returns |
You probably need to run |
@ghing Oh, gotcha. So I need to add the canonical names first before I write the transform portion? Because I started on the transform two days ago, but I ran into this roadblock last night and not even #python or #mongodb or mongoengine's docs could help me. |
@EricLagerg Yeah, you'll need to prepopulate Office and Party records to be able to fill in the relation fields on the other models. |
Gotcha also add a call at the end of why 96 on the Washington's loader module you're missing it and it breaks the loader :) Eric Lagergren On Tue, Oct 14, 2014 at 9:08 PM, Geoffrey Hing notifications@github.com
|
@EricLagerg done in 75a73dc. Good catch. |
We've all been busy, so don't feel too bad. Let us know when you're back in the swing of things! |
Write the transforms and validators for Washington.
Fundamentally there should be a transform to create
Candidate
,Contest
andResult
records from theRawResult
records created in the loader. Use best judgement if you want to delegate this to multiple transform classes or functions. If you encounter ambiguities or the need to standardize things in the data, these will require transforms as well.Write validators to check values in results and whether aggregate queries match published racewide totals. I took a TDD approach and tried to write these before the transforms, but do whatever works for you.
Maryland is the only state that has transforms and validators so they're a reasonable reference.
Since these have only been implemented for one state so far, I'm open to feedback on the API.
The text was updated successfully, but these errors were encountered: