-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oep:(cspc,cspi,day2ops) propose schema changes for pool resources and workflow for day 2 ops #2595
Conversation
55fab21
to
48c462b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please provide CSP schema changes as well
2ac3010
to
9fb1a12
Compare
a03ce44
to
947025e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below are review comments from discussion between Ashutosh, me and Kiran:
- move 'poolSpec' from spec.nodes to spec (as per Kiran's comments
- there are too many 'name' fields in spec.nodes which would be confusing. So, make them more explanatory.
cc: @AmitKumarDas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Approved CSPC schema!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AutoProvisioning
of pool creation is supported via storagepoolclaim
When user creates auto spc
spc-controller will internally converts the spc to cspc so pool creations will be handled by cspc controller
.
Example spc:
apiVersion: openebs.io/v1alpha1
kind: StoragePoolClaim
metadata:
name: cstor-sparse
spec:
name: cstor-sparse
type: sparse
poolSpec:
poolType: striped
cacheFile: /tmp/pool1.cache
maxPools: 1
when user created above spc spc-controller will convert to cspc.
High level steps for converting spc to cspc:
- Build and create cspc from spc provided by the user.
- Add finalizers on spc.
Deletion of cspc:
- User should delete spc to delete cspc and pools
Internal work flow by spc controller:
Finalizers on spc will make sure below steps
- Remove finalizers on cspc.
- Delete corresponding cspc.
- Remove finalizers on spc.
c39c0d3
to
a3bc584
Compare
944b4b9
to
eb5e273
Compare
…urces Signed-off-by: Ashutosh Kumar <ashutosh.kumar@openebs.io>
eb5e273
to
7235a29
Compare
CStor Resources Schema Proposal
This PR proposes a schema change for the custom resources that are used for CStor pool provisioning.
The doc should be read in the following order:
Signed-off-by: Ashutosh Kumar ashutosh.kumar@openebs.io