Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate parameters volgroup with vgpattern in StorageClass #108

Open
mittachaitu opened this issue Jun 21, 2021 · 4 comments
Open

validate parameters volgroup with vgpattern in StorageClass #108

mittachaitu opened this issue Jun 21, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@mittachaitu
Copy link

Describe the problem/challenge you have
If the user specifies both volgroup & vgpattern in StorageClass parameters
currently, volgroup will take more precedence and in end, LVM volume will be
created on user-specified volgroup. This behavior is good if volgroup value
is sub-pattern of vgpattern but if both volgroup and vgpattern differs then
CSI driver should error out about discrepancy instead of silently accepting the changes.

Note: Since volgroup is a subpattern of vgpattern good to have only vgpattern support.

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

  • Add validation during CreateVolume request if both volgroup and
    vgpattern are specified and if they are not matching then the driver
    should error out.

Note: This validation will also handle backward compatibility issues.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
No

Environment:

  • LVM Driver version
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
@abhilashshetty04 abhilashshetty04 self-assigned this Jun 5, 2024
@abhilashshetty04 abhilashshetty04 added the enhancement New feature or request label Jun 5, 2024
@abhilashshetty04
Copy link
Contributor

abhilashshetty04 commented Jun 5, 2024

@mittachaitu , We will add this as enhancements in our roadmap item. However, I dont see where user will provide vgpattern and volgroup together.
As i see vgpattern * wildcard as suffix in the arg. Using which schedular should return subset of matching vg hosting nodes.
However, volgroup is more definate selection process. Provisioner should return lvmnodes hosting vg which is exact match to the volgroup value.

@dsharma-dc
Copy link
Contributor

@abhilashshetty04 Do we really want to handle this?

@avishnu avishnu changed the title depricate support of volgroup parameter in StorageClass deprecate support of volgroup parameter in StorageClass Sep 12, 2024
@avishnu avishnu added this to the v4.2 milestone Sep 12, 2024
@avishnu
Copy link
Member

avishnu commented Sep 12, 2024

Scoped for OpenEBS v4.2

@tiagolobocastro tiagolobocastro changed the title deprecate support of volgroup parameter in StorageClass validate parameters volgroup with vgpattern in StorageClass Sep 12, 2024
@avishnu
Copy link
Member

avishnu commented Dec 17, 2024

Moving this out of the 4.2 release.

@avishnu avishnu removed this from the v4.2 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants