feat(charts): add global.imageRegistry parameter #227
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add global.imageRegistry option overridden by localpv.image.registry and helperPod.image.registry for localpv and helper Pod respectively. Fix registry options requiring a trailing slash while still supporting a trailing slash to avoid breaking existing configurations. Signed-off-by: Lior Friedman <lior@sneakybugs.com>
Signed-off-by: Lior Friedman <lior@sneakybugs.com>
Signed-off-by: Lior Friedman <lior@sneakybugs.com>
|
I tried to force push to re-run the CI job, it seems to have failed before installing the chart in the integration test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Why is this PR required? What issue does it fix?:
Fixes #203.
What this PR does?:
global.imageRegistryHelm parameter for specifying an image registry to be used for all images. It is overridden bylocalpv.image.registryandhelperPod.image.registrywhen specified./, while still supporting a trailing/to avoid breaking existing configurations.Does this PR require any upgrade changes?:
No.
If the changes in this PR are manually verified, list down the scenarios covered::
global.imageRegistryset without trailing/.global.imageRegistryandlocalpv.image.registryset without trailing/.global.imageRegistryandhelperPod.image.registryset without trailing/.global.imageRegistry,localpv.image.registryandhelperPod.image.registryset without trailing/.localpv.image.registryset with trailing/.helperPod.image.registryset with trailing/.Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
No.
Checklist:
<type>(<scope>): <subject>