RHOAIENG-15772: tests(odh-nbc): fix unintended shadowing of cfg variable
#462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iable This is a nasty Go gotcha, and we aren't the first to have trouble with it https://temporal.io/blog/go-shadowing-bad-choices#the-bug
Merged
3 tasks
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 658c81d
into
opendatahub-io:main
15 checks passed
|
Shipping this up to Kubeflow in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHOAIENG-15772
Description
cfgis first declared herekubeflow/components/odh-notebook-controller/controllers/suite_test.go
Lines 57 to 64 in e7980b1
and then the
:=operator shadows it, and thecfgwe are setting is a differentcfg. The topcfgremainsnil.kubeflow/components/odh-notebook-controller/controllers/suite_test.go
Line 101 in e7980b1
This is a nasty Go gotcha, and we aren't the first to have trouble with it. C.f. https://temporal.io/blog/go-shadowing-bad-choices#the-bug for one.
How Has This Been Tested?
Merge criteria: