Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extra cast causes rounding problems for scale #26658

Draft
wants to merge 9 commits into
base: 4.x
Choose a base branch
from
Draft

extra cast causes rounding problems for scale #26658

wants to merge 9 commits into from

Conversation

denshade
Copy link

@denshade denshade commented Dec 21, 2024 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Related to #26588

@denshade denshade mentioned this pull request Dec 21, 2024
Open
4 tasks
@isenberg
Copy link

Looks good and safe as other datatypes than float32 are handled separately in the else. I would have avoided the 2nd change around src.convertTo which is only adding { } but otherwise the code is identical also looks fine to be included.

isenberg
isenberg approved these changes Dec 21, 2024
View reviewed changes
Copy link

@isenberg isenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and safe as other datatypes than float32 are handled separately in the else. I would have avoided the 2nd change around src.convertTo which is only adding { } but otherwise the code is identical also looks fine to be included.

@denshade denshade marked this pull request as draft December 21, 2024 20:16
@denshade
Copy link
Author

Looks like a unit test is failing now. I'll need to look into that

denshade
denshade commented Dec 22, 2024
View reviewed changes
modules/core/src/norm.cpp
float shift_float = (float)dmin - (float)(smin * scale);

// check if a rounding error will occur, we want the values to be in [dmin, dmax]
if (rounds_outside_interval(smin, smax, scale_float, shift_float, dmin, dmax)) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if anyone knows an analytical solution, please share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isenberg isenberg isenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denshade @isenberg