-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump h2 from 1.3.176 to 2.2.220 #5103
base: develop
Are you sure you want to change the base?
Conversation
Bumps [h2](https://github.com/h2database/h2database) from 1.3.176 to 2.2.220. - [Release notes](https://github.com/h2database/h2database/releases) - [Commits](https://github.com/h2database/h2database/commits/version-2.2.220) --- updated-dependencies: - dependency-name: com.h2database:h2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
The new version of H2 does not like it if SQL keywords are used as column names, causing several tests to fail. Since we do not actually care for those names in the test specific tables, this just changes them to `a` and `b`. In the non-test cases, we try escaping instead.
…hopefully can update fully prior to merging this PR.
For those curious, the original PR where I started work on this is #3269 |
You guys might be interested in this Q&A. I just ran into it while looking at opencast/annotation-tool#611 again. The upshot: Quoting SQL keywords if we use them as identifiers is probably not enough, you also want to uppercase them since H2 is case-sensitive when it comes to its names, but also uppercases bare identifiers by default. Oh, and to complicate things further, replacing FWIW Postgres breaks the SQL spec here. |
This pull request has conflicts ☹ |
FYI: Branch cut for OC 17 is on November 6! |
Bumps h2 from 1.3.176 to 2.2.220.
Release notes
Sourced from h2's releases.
... (truncated)
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.