Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump h2 from 1.3.176 to 2.2.220 #5103

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 7, 2023

Bumps h2 from 1.3.176 to 2.2.220.

Release notes

Sourced from h2's releases.

Version 2.2.220

Changes since 2.1.214 release:

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [h2](https://github.com/h2database/h2database) from 1.3.176 to 2.2.220.
- [Release notes](https://github.com/h2database/h2database/releases)
- [Commits](https://github.com/h2database/h2database/commits/version-2.2.220)

---
updated-dependencies:
- dependency-name: com.h2database:h2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jul 7, 2023
lkiesow and others added 3 commits July 12, 2023 11:23
The new version of H2 does not like it if SQL keywords are used as
column names, causing several tests to fail.

Since we do not actually care for those names in the test specific
tables, this just changes them to `a` and `b`.  In the non-test cases,
we try escaping instead.
…hopefully can update fully prior to merging this PR.
@gregorydlogan
Copy link
Member

For those curious, the original PR where I started work on this is #3269

@gregorydlogan gregorydlogan self-assigned this Jul 13, 2023
@JulianKniephoff
Copy link
Member

JulianKniephoff commented Jul 26, 2023

You guys might be interested in this Q&A. I just ran into it while looking at opencast/annotation-tool#611 again.

The upshot: Quoting SQL keywords if we use them as identifiers is probably not enough, you also want to uppercase them since H2 is case-sensitive when it comes to its names, but also uppercases bare identifiers by default.


Oh, and to complicate things further, replacing value with "VALUE" also doesn't work, because Postgres lowercases bare identifiers by default. So a change from an unquoted identifier to a quoted one will always be a breaking change for someone. 👌

FWIW Postgres breaks the SQL spec here.

Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@KatrinIhler
Copy link
Member

FYI: Branch cut for OC 17 is on November 6!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file has-conflicts java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants