Skip to content

Commit

Permalink
Add offset to selectParams (prometheus#4226)
Browse files Browse the repository at this point in the history
* Add Start/End to SelectParams
* Make remote read use the new selectParams for start/end

This commit will continue sending the start/end time of the remote read
query as the overarching promql time and the specific range of data that
the query is intersted in receiving a response to is now part of the
ReadHints (upstream discussion in prometheus#4226).

* Remove unused vendored code

The genproto.sh script was updated, but the code wasn't regenerated.
This simply removes the vendored deps that are no longer part of the
codegen output.

Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>
  • Loading branch information
jacksontj authored and brian-brazil committed Jul 18, 2018
1 parent 96fb0b2 commit 92c6f0c
Show file tree
Hide file tree
Showing 22 changed files with 221 additions and 5,213 deletions.
18 changes: 18 additions & 0 deletions prompb/remote.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

43 changes: 31 additions & 12 deletions prompb/rpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions prompb/rpc.pb.gw.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

156 changes: 124 additions & 32 deletions prompb/types.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions prompb/types.proto
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ message LabelMatcher {
}

message ReadHints {
int64 step_ms = 1; // Query step size in milliseconds.
string func = 2; // String representation of surrounding function or aggregation.
int64 step_ms = 1; // Query step size in milliseconds.
string func = 2; // String representation of surrounding function or aggregation.
int64 start_ms = 3; // Start time in milliseconds.
int64 end_ms = 4; // End time in milliseconds.
}
Loading

0 comments on commit 92c6f0c

Please sign in to comment.