Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some if there is no upcoming conference #2707

Open
peterdd opened this issue Jan 2, 2021 · 6 comments
Open

add some if there is no upcoming conference #2707

peterdd opened this issue Jan 2, 2021 · 6 comments
Labels
bug 🐛 Something is wrong and needs to be fixed good first issue For RoR beginners or people unfamiliar with the application

Comments

@peterdd
Copy link

peterdd commented Jan 2, 2021

I do not know if this is the right place, but if there is no upcoming conference a paragraph telling that would be nice.

Otherwise people might think the page is broken/data unavailable.

grafik

@hennevogel hennevogel added the bug 🐛 Something is wrong and needs to be fixed label Mar 7, 2021
@differentreality differentreality added the good first issue For RoR beginners or people unfamiliar with the application label Oct 19, 2022
@airbr
Copy link

airbr commented Dec 16, 2022

I am just leaving a comment to say that this is a good first issue, if it is still needed. I just need to get over the hurdle of installation to get it into a dev environment to test it out and format it.

I found in https://github.com/openSUSE/osem/blob/master/app/views/conferences/index.html.haml Line 6 just by looking:

- @current.each do |conference|
    = render '/conferences/conference_details', conference: conference

There needs to be something like:

- @current.each do |conference|
    = render '/conferences/conference_details', conference: conference
- if @current.empty?
    [TEXT HERE, Saying no upcoming conference]

@differentreality
Copy link
Contributor

@airbr How could we help you with the installation and first use of OSEM locally?

@airbr
Copy link

airbr commented Dec 20, 2022

@differentreality I have cloned the repo, bundle installed, a few things, Im trying to run the app locally with bin/rails server after running bin/rails db:create and bin/rails db:migrate but I keep getting errors in running the migrations. Ill document what I tried, but I also hacked around a fair bit trying to get the many migrations to pass. I might try again with a fresh install later.

@airbr
Copy link

airbr commented Dec 20, 2022

@differentreality I was able to successfully install and make an admin user on a development server.

I ran into a few issues as I went, and I dont know if there is a best way to document them or if they were just the result of my troublesome setup issues

@airbr
Copy link

airbr commented Dec 20, 2022

How does this look? I will fork and make a PR sometime

Screen Shot 2022-12-20 at 2 25 03 PM

@airbr
Copy link

airbr commented Dec 20, 2022

Maybe we should additionally hide the Add the events to your calendar buttons if there is no current conference? @differentreality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something is wrong and needs to be fixed good first issue For RoR beginners or people unfamiliar with the application
Projects
None yet
Development

No branches or pull requests

4 participants