fix: remove error on explain analyze select into clause #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #309
What is changed and how it works?
When running these codes, the ctx has no value WRITER_CONTEXT, so ctx.Value(WRITER_CONTEXT) is nil. It can be fixed by adding ctx value before executing explain analyze statement.
Also, we don't want to really write data when executing
explain analyze select into
, so we can define a dummy writer, which will write the data intoio.Discard
.How Has This Been Tested?
I insert some data into db0..cpu_load, and try
explain analyze select * into db1..cpuload from db0..cpu_load
, it works properly:Also I add integretion test:
Checklist: