Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[instrumentation-mysql2] tests time out for mysql2@3.11.5 #2572

Closed
pichlermarc opened this issue Dec 2, 2024 · 3 comments · Fixed by #2579
Closed

[instrumentation-mysql2] tests time out for mysql2@3.11.5 #2572

pichlermarc opened this issue Dec 2, 2024 · 3 comments · Fixed by #2579
Labels
bug Something isn't working pkg:instrumentation-mysql2 priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect

Comments

@pichlermarc
Copy link
Member

Description

On main the TAV tests for mysql2@3.11.5 are currently timing out. Since assertions are failing on that version, I'd assume that also telemetry is being dropped, hence categorizing this as priority:p2.

See release: https://github.com/sidorares/node-mysql2/releases/tag/v3.11.5
See failing workflow: https://github.com/open-telemetry/opentelemetry-js-contrib/actions/runs/12107327068/job/33754171979
@pichlermarc pichlermarc added bug Something isn't working priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect pkg:instrumentation-mysql2 labels Dec 2, 2024
@pichlermarc pichlermarc mentioned this issue Dec 2, 2024
Merged
@pichlermarc
Copy link
Member Author

looks like connection and query got split and now it's not patching it correctly anymore.

@pichlermarc
Copy link
Member Author

pichlermarc commented Dec 2, 2024 •
edited
Loading

I believe that this is related to sidorares/node-mysql2#3081
Edit: and #1511

@liustve liustve mentioned this issue Dec 4, 2024
Open
@pichlermarc pichlermarc mentioned this issue Dec 4, 2024
Merged
@pichlermarc
Copy link
Member Author

This is a release blocker for core 1.29.0/0.56.0 - see open-telemetry/opentelemetry-js#5232

@pichlermarc pichlermarc linked a pull request Dec 4, 2024 that will close this issue
fix(instr-mysql2): Fix mysql2 instrumentation connection prototype #2578
Closed
@pichlermarc pichlermarc mentioned this issue Dec 4, 2024
Merged
@david-luna david-luna mentioned this issue Dec 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working pkg:instrumentation-mysql2 priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect
Projects
None yet
Milestone
No milestone
1 participant
@pichlermarc