Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintainers: Add dyladan, remove danielkhan #607

Merged
merged 2 commits into from
Dec 11, 2019
Merged

Maintainers: Add dyladan, remove danielkhan #607

merged 2 commits into from
Dec 11, 2019

Conversation

danielkhan
Copy link
Contributor

As my responsibilities have changed and @dyladan is doing a great job in this SIG, I am nominating him to take over maintainership from me.

GitHub Username

@dyladan

Organization you are requesting membership in

opentelemetry-js

Requirements

Responsibilities

  • Make and approve technical design decisions for the subproject.
  • Set technical direction and priorities for the subproject.
  • Define milestones and releases.
  • Mentor and guide approvers, reviewers, and contributors to the subproject.
  • Escalate reviewer and maintainer workflow concerns (i.e. responsiveness, availability, and general contributor community health) to the TC.
  • Ensure continued health of subproject:
  • Adequate test coverage to confidently release
  • Tests are passing reliably (i.e. not flaky) and are fixed when they fail
  • Ensure a healthy process for discussion and decision making is in place.
  • Work with other maintainers to maintain the project's overall health and success holistically.

Sponsors

List of contributions to the OpenTelemetry project

@codecov-io
Copy link

Codecov Report

Merging #607 into master will increase coverage by 1.39%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #607      +/-   ##
=========================================
+ Coverage    92.2%   93.6%   +1.39%     
=========================================
  Files         183     178       -5     
  Lines        9093    8892     -201     
  Branches      798     785      -13     
=========================================
- Hits         8384    8323      -61     
+ Misses        709     569     -140
Impacted Files Coverage Δ
...es/opentelemetry-node/src/instrumentation/utils.ts 90.47% <0%> (-9.53%) ⬇️
packages/opentelemetry-plugin-mysql/src/utils.ts 90.9% <0%> (-4.55%) ⬇️
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <0%> (ø) ⬆️
...opentelemetry-base/test/resources/resource.test.ts 100% <0%> (ø) ⬆️
...ges/opentelemetry-exporter-zipkin/src/transform.ts 100% <0%> (ø) ⬆️
...try-node/test/instrumentation/PluginLoader.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-exporter-zipkin/test/zipkin.test.ts 100% <0%> (ø) ⬆️
...pe-async-hooks/test/AsyncHooksScopeManager.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-exporter-jaeger/test/jaeger.test.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-plugin-https/src/utils.ts 100% <0%> (ø) ⬆️
... and 11 more

@mayurkale22 mayurkale22 merged commit d32565a into open-telemetry:master Dec 11, 2019
@Flarna Flarna deleted the dkhan-add-dyladan branch December 13, 2019 20:30
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
@dyladan
Maintainers: Add dyladan, remove danielkhan (open-telemetry#607)
c9b6e9e 
* chore: add dyladan remove danielkhan

* chore: removed formatting
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
@dyladan
chore: add component owners to readme (open-telemetry#607)
a295efe
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 13, 2024
@dyladan
chore: add component owners to readme (open-telemetry#607)
96c539b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@markwolff markwolff markwolff approved these changes

@OlivierAlbertini OlivierAlbertini OlivierAlbertini approved these changes

@draffensperger draffensperger draffensperger approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@bg451 bg451 Awaiting requested review from bg451

@obecny obecny Awaiting requested review from obecny

@rochdev rochdev Awaiting requested review from rochdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@danielkhan @codecov-io @vmarchaud @draffensperger @OlivierAlbertini @markwolff @mayurkale22