Add initial experimental SDK self-observability metric #6153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n_processor.queue_size metric
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6153 +/- ##
=======================================
- Coverage 82.2% 82.2% -0.1%
=======================================
Files 273 273
Lines 23674 23706 +32
=======================================
+ Hits 19478 19492 +14
- Misses 3849 3864 +15
- Partials 347 350 +3 |
MrAlias
reviewed
Jan 10, 2025
dashpole
commented
Jan 11, 2025
| metric.WithInstrumentationVersion(version()), | ||
| ) | ||
|
|
||
| queueSizeCounter, err := meter.Int64ObservableUpDownCounter("otel.sdk.batch_span_processor.queue_size", |
There was a problem hiding this comment.
I just realized that there isn't a good way to distinguish different instances of the batch span processor. I think we might want to use a scope attribute to do that, but i'm not sure what the attribute should be. We don't have any unique identifiers for exporters or processors. We could generate one, but that doesn't seem very helpful.
|
Turns out there are already proposed semantic conventions: open-telemetry/semantic-conventions#1631 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2547
This adds the
OTEL_GO_X_SELF_OBSERVABILITYfeature gate, theotel.sdk.batch_span_processor.queue_sizemetric behind it. I tried to pick the least contentious metric to start with.Note: I opted for a single environment variable for all SDKs and for all signals, rather than multiple environment variables.
TODO: