Kafka and RabbitMQ instrumentation adding activity links after creation #3985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharycmontoya
approved these changes
Jan 29, 2025
pjanotti
approved these changes
Jan 30, 2025
|
Converting to draft for now, Yevhenii is planning additional changes. |
…m/ysolomchenko/opentelemetry-dotnet-instrumentation into add-activity-links-after-creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Due to inability to add activity links after activity’s creation, some instrumentations (e.g related to messaging) capture activity start time at the start of receive operations, and start the activity and stop them immediately at the end of it, setting the start time to captured value, to work around the limitation.
S.D.DS v9 ships with the ability to add activity links after creation. Instrumentation should be adjusted to benefit from the improved API.
What
Kafka and RabbitMQ instrumentation now use the new S.D.DS v9 API for adding activity links after creation, removing the need for manual start time adjustments
Tests
Ci
Checklist
CHANGELOG.mdis updated.Documentation is updated.New features are covered by tests.