[exporter/prometheusremotewrite] only append colliding attributes values if they are different #36928
+46
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… values if they are different
github-actions
bot
requested review from
ArthurSens,
bertysentry and
dashpole
avanish-vaghela
changed the title
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Hi @dashpole, can I get review on this PR please? |
|
@avanish-vaghela it is still a draft. Feel free to mark it ready for review as soon as you are finished with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While translating two OTel attributes into Prometheus Labels, if both attributes results in the same Prometheus label and both have the same value, they won't be appended.
Example:
The above two attributes when translated to Prometheus label would become
Link to tracking issue
Fixes #35896
Testing
Documentation