Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix add_config func is not called bug #613

Merged
merged 10 commits into from
Oct 24, 2022
Merged

fix add_config func is not called bug #613

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c63c6ea
fix add_config func is not called bug
shenmishajing Oct 15, 2022
cb5ec33
move log_code_name param to the last one
shenmishajing Oct 16, 2022
6ae9c20
add config only when there is a cfg
shenmishajing Oct 16, 2022
977dd7f
Merge remote-tracking branch 'fork/fix_add_config_is_not_called_bug' …
shenmishajing Oct 16, 2022
ec7b353
add unit test for log_code_name param of WandbVisBackend
shenmishajing Oct 16, 2022
60353da
Update mmengine/visualization/vis_backend.py
shenmishajing Oct 16, 2022
4c90dc5
use log_code_kwargs instead of only log_code_name
shenmishajing Oct 19, 2022
4eb0ae7
use log_code_kwargs instead of only log_code_name
shenmishajing Oct 19, 2022
51b2f35
fix add config unit test
shenmishajing Oct 19, 2022
47bdfa0
roll back to log_code_name version
shenmishajing Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix add config unit test
  • Loading branch information
@shenmishajing
shenmishajing committed Oct 19, 2022
commit 51b2f35fd0b2c71202b058b99b958305618857e7
3 changes: 2 additions & 1 deletion tests/test_visualizer/test_vis_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,8 @@ def test_experiment(self):

def test_add_config(self):
cfg = Config(dict(a=1, b=dict(b1=[0, 1])))
wandb_vis_backend = WandbVisBackend('temp_dir', log_code_name='code')
wandb_vis_backend = WandbVisBackend(
'temp_dir', log_code_kwargs=dict(name='code'))
_wandb = wandb_vis_backend.experiment
_wandb.run.dir = 'temp_dir'
wandb_vis_backend.add_config(cfg)
Expand Down