Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onnx-weekly has inconsistent version metadata #5931

Open
Andreas-Krebbel opened this issue Feb 12, 2024 · 6 comments
Open

onnx-weekly has inconsistent version metadata #5931

Andreas-Krebbel opened this issue Feb 12, 2024 · 6 comments
Labels
bug contributions welcome good first issue Good for getting started topic: build Issues related to ONNX builds and packages

Comments

@Andreas-Krebbel
Copy link

Andreas-Krebbel commented Feb 12, 2024 •
edited by justinchuby
Loading

Bug Report

Is the issue related to model conversion?

No

Describe the bug

Compiling the onnx-weekly package during installation fails due to inconsistent meta data:

$ pip install --no-binary :all: onnx-weekly
Looking in indexes: https://pypi.org/simple, https://pypi.ngc.nvidia.com
Collecting onnx-weekly
  Downloading onnx-weekly-1.16.0.dev20240205.tar.gz (12.3 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 12.3/12.3 MB 8.2 MB/s eta 0:00:00
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Installing backend dependencies ... done
  Preparing metadata (pyproject.toml) ... done
Discarding https://files.pythonhosted.org/packages/20/f2/bf15d54fd4e661f1e5f3df79fbbbbc32ac5e4912154ed0ea6f2854dc3540/onnx-weekly-1.16.0.dev20240205.tar.gz (from https://pypi.org/simple/onnx-weekly/) (requires-python:>=3.8): Requested onnx-weekly from https://files.pythonhosted.org/packages/20/f2/bf15d54fd4e661f1e5f3df79fbbbbc32ac5e4912154ed0ea6f2854dc3540/onnx-weekly-1.16.0.dev20240205.tar.gz has inconsistent version: expected '1.16.0.dev20240205', but metadata has '1.16.0'

Building the source package directly from the tarball works though:
pip install https://files.pythonhosted.org/packages/20/f2/bf15d54fd4e661f1e5f3df79fbbbbc32ac5e4912154ed0ea6f2854dc3540/onnx-weekly-1.16.0.dev20240205.tar.gz

What also works is installation with the older resolver engine:
pip install --use-deprecated=legacy-resolver --no-binary :all: onnx-weekly

System information

  • Fedora 38 on x86-64

Reproduction instructions

pip install --no-binary :all: onnx-weekly

Expected behavior

Build and install onnx-weekly package

Notes
@xadupre
Copy link
Contributor

xadupre commented Feb 13, 2024

pypi can't find a compiled version suitable for your environment (https://pypi.org/project/onnx-weekly/#files). Which python are you using?

@Andreas-Krebbel
Copy link
Author

I have intentionally ignored the binary wheel packages (--no-binary :all:) to trigger the behavior which otherwise can be observed on platforms where there is no binary available at all. I originally ran into this on s390x.

@xadupre
Copy link
Contributor

xadupre commented Feb 13, 2024

Sorry, I misunderstood your initial question. +@justinchuby

@justinchuby justinchuby changed the title pip install onnx-weekly fails when enforcing rebuild ONNX weekly has inconsistent version metadata Feb 13, 2024
@justinchuby justinchuby added topic: build Issues related to ONNX builds and packages contributions welcome labels Feb 13, 2024
@justinchuby
Copy link
Contributor

justinchuby commented Feb 13, 2024 •
edited
Loading

Looks like we needed to set the version metadata correctly to resolve "[...] has inconsistent version: expected '1.16.0.dev20240205', but metadata has '1.16.0'"

@justinchuby justinchuby changed the title ONNX weekly has inconsistent version metadata onnx-weekly has inconsistent version metadata Feb 13, 2024
@andife andife added the good first issue Good for getting started label Mar 28, 2024
@andife
Copy link
Member

andife commented Jul 13, 2024

I would assume the tar.gz which could be find here, p.ex. https://pypi.org/project/onnx-weekly/#files:

onnx_weekly-1.17.0.dev20240708.tar.gz (11.4 MB view hashes) Uploaded 8. Juli 2024 Source

should have the correct version in it...

Therefore changing the Number in onnx_weekly-1.17.0.dev20240708.tar.gz\onnx_weekly-1.17.0.dev20240708\VERSION_NUMBER should work

I wonder at which step is the tar.gz generated? Otherwise one could simply patch the file beforehand?

@andife
Copy link
Member

andife commented Jul 13, 2024

The tar.gz is built at

onnx/.github/workflows/release_mac.yml

Line 142 in c7717bb

ONNX_PREVIEW_BUILD=1 python -m build --sdist

ONNX_PREVIEW_BUILD=1 python -m build --sdist

If I understand this correctly, I have the opinion that it is quite hidden and should not be assigned to a specific OS pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug contributions welcome good first issue Good for getting started topic: build Issues related to ONNX builds and packages
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@justinchuby @andife @xadupre @Andreas-Krebbel