-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configure auto startup in macos #7097
Open
hichemfantar
wants to merge
7
commits into
ollama:main
Choose a base branch
from
hichemfantar:configure-auto-startup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+85
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hichemfantar
changed the title
Add toggleAutoStartup function and menu item
Add toggleAutoStartup function and menu item in macos
Oct 4, 2024
hichemfantar
changed the title
Add toggleAutoStartup function and menu item in macos
feat: Add toggleAutoStartup function and menu item in macos
Oct 4, 2024
hichemfantar
changed the title
feat: Add toggleAutoStartup function and menu item in macos
feat: configure auto startup in macos
Oct 4, 2024
vignesh1507
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with the changes.
@jmorganca @mchiang0610 can we get this merged? |
@BruceMacD do you think you can merge this since it’s highly requested by the community |
This was referenced Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new function called
toggleAutoStartup
and a corresponding menu item to the application. The function allows the user to enable or disable auto startup of the application. When the function is called, it updates the application's login item settings and displays a notification to indicate whether auto startup is enabled or disabled. The menu item is added to the tray menu and allows the user to easily toggle the auto startup setting. Additionally, the tray menu is now updated when clicked to avoid displaying stale information.closes #162
Screen.Recording.2024-10-20.at.12.21.28.AM.mp4