Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix embeddings memory corruption #6467

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Fix embeddings memory corruption #6467

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8972fd2
Fix embeddings memory corruption
dhiltgen Aug 22, 2024
9c33cd1
Fix embed integration test assumption
dhiltgen Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix embed integration test assumption 
The token eval count has changed with recent llama.cpp bumps (0.3.5+)
  • Loading branch information
@dhiltgen
dhiltgen committed Aug 22, 2024
commit 9c33cd14ce074a3889eca1aed4c730b04f39af93
8 changes: 4 additions & 4 deletions integration/embed_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ func TestAllMiniLMEmbed(t *testing.T) {
t.Fatalf("expected 0.010071031, got %.8f", res.Embeddings[0][0])
}

if res.PromptEvalCount != 8 {
t.Fatalf("expected 8 prompt tokens, got %d", res.PromptEvalCount)
if res.PromptEvalCount != 6 {
t.Fatalf("expected 6 prompt tokens, got %d", res.PromptEvalCount)
}
}

Expand Down Expand Up @@ -102,8 +102,8 @@ func TestAllMiniLMBatchEmbed(t *testing.T) {
t.Fatalf("expected 0.010071031 and -0.009802706, got %.8f and %.8f", res.Embeddings[0][0], res.Embeddings[1][0])
}

if res.PromptEvalCount != 16 {
t.Fatalf("expected 16 prompt tokens, got %d", res.PromptEvalCount)
if res.PromptEvalCount != 12 {
t.Fatalf("expected 12 prompt tokens, got %d", res.PromptEvalCount)
}
}

Expand Down
Loading