Skip to content

Commit

Permalink
Merge remote-tracking branch 'upstream/staging' into feature/custom_i…
Browse files Browse the repository at this point in the history
…mage

* upstream/staging: (36 commits)
  docs(documentation): Update readme.md and contributor.md (freeCodeCamp#16990)
  feat: Allows sharing of network (freeCodeCamp#16937)
  fix(seed): Correct typos in es6.json (freeCodeCamp#16972)
  fix(seed): Add test for checking the length of buttons is 2 (freeCodeCamp#16921)
  fix(challenges): Change Symmetric Differences Title (freeCodeCamp#16962)
  fix(challenges): Fix typo in css-grid justify-self challenge (freeCodeCamp#16961)
  chore(package): Update react-freecodecamp-search (freeCodeCamp#16943)
  fix(seed): Fixed issue with approximately always failing (freeCodeCamp#16752)
  fix(lang): Refetch mapUi on language change (freeCodeCamp#16844)
  fix(seed): Make element naming optional (freeCodeCamp#16926)
  fix(seed): Chall seed and test are modified to allow better t (freeCodeCamp#16928)
  fix(projects): Add user stories to projects' description (freeCodeCamp#16924)
  feat(seed): An HTML illustration added (freeCodeCamp#16939)
  fix(gulp): run babel-node with inspect flag in debug (freeCodeCamp#16901)
  fix: remove flash saying JS is disabled
  fix(common): Added expected homeURL that was missing (freeCodeCamp#16922)
  fix(settings): Night mode settings and profile page UI improvements (freeCodeCamp#16806)
  style(settings): Remove extra whitespace
  fix(settings): Report user modal centered to the page
  fix(settings): Fix modal success button hover animation
  ...
  • Loading branch information
ojongerius committed Apr 3, 2018
2 parents aa45532 + ee051d4 commit 98b0aac
Show file tree
Hide file tree
Showing 48 changed files with 2,750 additions and 409 deletions.
29 changes: 28 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -271,9 +271,11 @@ npm run develop
```

Now navigate to your browser and open <http://localhost:3000>. If the app loads, congratulations – you're all set.

Otherwise, let us know by asking in the [Contributors chat room](https://gitter.im/FreeCodeCamp/Contributors) on Gitter. There might be an error in the console of your browser or in Bash / Terminal / Command Line that will help identify the problem.

If the app launches but you are encountering errors with the UI itself, for example if fonts are not being loaded or if the code editor is not displaying properly, you may try the following:

```bash
# Remove all installed node modules
rm -rf node_modules
Expand All @@ -288,6 +290,31 @@ node seed
npm run develop
```

### Setup freeCodeCamp using Docker
#### Isolated
Use this if you just want to work on freeCodeCamp.

You will need to have [docker](https://docs.docker.com/install/) and [docker-compose](https://docs.docker.com/compose/install/) installed before executing the commands below.

Setup:
```bash
docker-compose run --rm freecodecamp npm install
docker-compose run --rm freecodecamp npm run only-once
```

Run:
```bash
docker-compose up
```

#### Shared
Use this if you want to work on other services that will run alongside
of freeCodeCamp, using the database directly. An example is the [open-api](https://github.com/freeCodeCamp/open-api) project.

```bash
docker-compose -f docker-compose.yml -f docker-compose-shared.yml up
```

### Make Changes

This bit is up to you!
Expand Down Expand Up @@ -454,7 +481,7 @@ freeCodeCamp has a team of volunteer Issue Moderators. These Issue Moderators ro

2. Another Issue Moderator will QA the same pull request. Once they have also confirmed that the new code does what it is supposed to without seeming to introduce any new bugs, they will merge the pull request.

If you would like to apply to join our Issue Moderator team - which is a Core Team position - message [@BerkeleyTrue](https://gitter.im/berkeleytrue) with links to 5 of your pull requests that have been accepted and 5 issues where you have helped someone else through commenting or QA'ing.
If you would like to apply to join our Issue Moderator team, message [@quincylarson](https://gitter.im/quincylarson) with links to 5 of your pull requests that have been accepted and 5 issues where you have helped someone else through commenting or QA'ing.

### How We Close Stale Issues

Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

[![Throughput Graph](https://graphs.waffle.io/freecodecamp/freecodecamp/throughput.svg)](https://waffle.io/freecodecamp/freecodecamp/metrics)

[![Join the chat at https://gitter.im/freecodecamp/freecodecamp](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/freecodecamp/freecodecamp?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
[![Known Vulnerabilities](https://snyk.io/test/github/freecodecamp/freecodecamp/badge.svg)](https://snyk.io/test/github/freecodecamp/freecodecamp)
[![Build Status](https://travis-ci.org/freeCodeCamp/freeCodeCamp.svg?branch=staging)](https://travis-ci.org/freeCodeCamp/freeCodeCamp)
[![Pull Requests Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg?style=flat)](http://makeapullrequest.com)
Expand Down Expand Up @@ -45,7 +44,7 @@ For this certification, you'll work on **two projects from scratch** and then **

---

This code is running live at [freeCodeCamp.org](https://www.freecodecamp.org). We also have [Gitter chat rooms](https://gitter.im/FreeCodeCamp/FreeCodeCamp), a [Medium publication](https://medium.freecodecamp.org), an [interactive forum](https://forum.freecodecamp.org), a [wiki knowledgebase](https://forum.freecodecamp.org/c/wiki), local [FaceBook groups](https://study-group-directory.freecodecamp.org/), and even a [YouTube channel](https://youtube.com/freecodecamp).
This code is running live at [freeCodeCamp.org](https://www.freecodecamp.org). We also have a super active [forum](https://forum.freecodecamp.org), [local study groups](https://study-group-directory.freecodecamp.org/), a [Medium publication](https://medium.freecodecamp.org), a [guide to thousands of programming topics](https://guide.freecodecamp.org), and even a [YouTube channel](https://youtube.com/freecodecamp).

### [Join our community here](https://www.freecodecamp.org/signin).

Expand Down
2 changes: 1 addition & 1 deletion client/less/lib/bootstrap/variables.less
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@
@grid-gutter-width: 30px;
// Navbar collapse
//** Point at which the navbar becomes uncollapsed.
@grid-float-breakpoint: @screen-sm-min;
@grid-float-breakpoint: 955px;
//** Point at which the navbar begins collapsing.
@grid-float-breakpoint-max: (@grid-float-breakpoint - 1);

Expand Down
17 changes: 17 additions & 0 deletions client/less/main.less
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,16 @@ h1, h2, h3, h4, h5, h6, p, li {
margin-top: 20px;
}

.not-found, .not-found .btn-primary {
display: grid;
margin: auto;
a:hover,
a:focus,
a:active {
text-decoration: none;
}
}

// Thumbnails
// -------------------------

Expand Down Expand Up @@ -923,9 +933,16 @@ and (max-width : 400px) {
// Account Modal Styles
.modal-dialog {
margin: 80px;
bottom: 48px;

.modal-content {
background-color: #f9f9f9;

.btn-success:hover,
.btn-success:focus,
.btn-success:active {
background: #457E86;
}
}

.modal-header .close {
Expand Down
5 changes: 5 additions & 0 deletions common/app/Flash/flash.less
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,8 @@
flex: 1 0 0px;
color: #37474f;
}

#@{ns}-board {
margin-top: 50px;
}

43 changes: 43 additions & 0 deletions common/app/Nav/LargeNav.jsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
import React from 'react';
import Media from 'react-media';
import { Col, Navbar, Row } from 'react-bootstrap';
import FCCSearchBar from 'react-freecodecamp-search';
import { NavLogo, BinButtons, NavLinks } from './components';

import propTypes from './navPropTypes';

function LargeNav({ clickOnLogo, clickOnMap, shouldShowMapButton, panes }) {
return (
<Media
query='(min-width: 956px)'
render={
() => (
<Row>
<Col className='nav-component' sm={ 4 } xs={ 6 }>
<Navbar.Header>
<NavLogo clickOnLogo={ clickOnLogo } />
<FCCSearchBar />
</Navbar.Header>
</Col>
<Col className='nav-component bins' sm={ 4 } xs={ 6 }>
<BinButtons panes={ panes } />
</Col>
<Col className='nav-component nav-links' sm={ 4 } xs={ 0 }>
<Navbar.Collapse>
<NavLinks
clickOnMap={ clickOnMap }
shouldShowMapButton={ shouldShowMapButton }
/>
</Navbar.Collapse>
</Col>
</Row>
)
}
/>
);
}

LargeNav.displayName = 'LargeNav';
LargeNav.propTypes = propTypes;

export default LargeNav;
47 changes: 47 additions & 0 deletions common/app/Nav/MediumNav.jsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
import React from 'react';
import Media from 'react-media';
import { Navbar, Row } from 'react-bootstrap';
import FCCSearchBar from 'react-freecodecamp-search';
import { NavLogo, BinButtons, NavLinks } from './components';

import propTypes from './navPropTypes';

function MediumNav({ clickOnLogo, clickOnMap, shouldShowMapButton, panes }) {
return (
<Media
query={{ maxWidth: 955, minWidth: 751 }}
>
{
matches => matches && typeof window !== 'undefined' && (
<div>
<Row>
<Navbar.Header className='medium-nav'>
<div className='nav-component header'>
<Navbar.Toggle />
<NavLogo clickOnLogo={ clickOnLogo } />
<FCCSearchBar />
</div>
<div className='nav-component bins'>
<BinButtons panes={ panes } />
</div>
</Navbar.Header>
</Row>
<Row className='collapse-row'>
<Navbar.Collapse>
<NavLinks
clickOnMap={ clickOnMap }
shouldShowMapButton={ shouldShowMapButton }
/>
</Navbar.Collapse>
</Row>
</div>
)
}
</Media>
);
}

MediumNav.displayName = 'MediumNav';
MediumNav.propTypes = propTypes;

export default MediumNav;
Loading

0 comments on commit 98b0aac

Please sign in to comment.