Pack all code in a class #4797
Replies: 4 comments 5 replies
-
|
I think there is some overlap with the idea from #4626 ideally you could even create a game manager that plays against two instances just created like in your above snippet. |
Beta Was this translation helpful? Give feedback.
-
|
Way too much global state for this to be useful. You would still be able to only make 1 instance. |
Beta Was this translation helpful? Give feedback.
-
|
right, would require significant work to remove all global state (most notably, TT and histories, but there is more) |
Beta Was this translation helpful? Give feedback.
-
|
would be beneficial, for example, to write light-weight datagen code for training, avoiding maintaining a separate tools branch. |
Beta Was this translation helpful? Give feedback.
-
|
We may solve that problem by two steps. First, pack all global variants into the SF class as static ones thus all code could be compiled and run quickly. Those variants could be removed/deleted manually by a function if we want. After that we may improve one by one, change from static to normal variants and/or make sure they could be created/removed properly. |
Beta Was this translation helpful? Give feedback.
-
Mhh, datagen still requires some changes here and there and a few engine devs disable certain pruning heuristics in search, so that light weight datagen code would only be temporarily I think. |
Beta Was this translation helpful? Give feedback.
-
|
Curious what is the current branch for datagen? I thought all of the
nodechip stuff was deprecated since the merger of lc0 data around SF14 or
15.
…On Sat, Sep 23, 2023 at 3:00 AM disservin ***@***.***> wrote:
would be beneficial, for example, to write light-weight datagen code for
training, avoiding maintaining a separate tools branch.
Mhh, datagen still requires some changes here and there and a few engine
devs disable certain pruning heuristics in search, so that light weight
datagen code would only be temporarily I think.
—
Reply to this email directly, view it on GitHub
<#4797 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABH7MEPWWNZEOKF4F6TLMH3X32CIVANCNFSM6AAAAAA5CYPQWQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: <official-stockfish/Stockfish/repo-discussions/4797/comments/7087607@
github.com>
|
Beta Was this translation helpful? Give feedback.
-
|
It's in the tools branch, https://github.com/official-stockfish/Stockfish/tree/tools. |
Beta Was this translation helpful? Give feedback.
-
|
Aye, at one point I generated just over 100gigs of binpacks but gave up
when I was told they were no longer being used. Instead previous ones,
nets, merged with the lc0 data and I guess since then it's the same net
just constant updates based on previous data. Was fun at the time and
enjoyed rolling NN's. The process seems past me now or at least more
closed off.
I still have a copy of those but figure they are somewhat pointless since
they were SF14 maybe early SF15.
…On Sat, Sep 23, 2023 at 3:11 AM disservin ***@***.***> wrote:
It's in the tools branch,
https://github.com/official-stockfish/Stockfish/tree/tools.
But it's probably a long time ago since someone has generated some data
using Stockfish.
—
Reply to this email directly, view it on GitHub
<#4797 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABH7MEI5GRDSLNHBZR5VMTDX32DTLANCNFSM6AAAAAA5CYPQWQ>
.
You are receiving this because you commented.Message ID:
<official-stockfish/Stockfish/repo-discussions/4797/comments/7087640@
github.com>
|
Beta Was this translation helpful? Give feedback.
-
Recently all SF’s code is packed in a namespace. IMO, it is a good improvement. I wonder if we could put it further, to pack all code in a class. Say, a class named Stockfish. The main function will look like:
It will take all advantages/benefits as having a namespace, plus some benefits from being able to create and destroy instances of the class:
Beta Was this translation helpful? Give feedback.
All reactions