Merge pull request bcpierce00#944 from tleedjarv/makefile-uimac

Clarify the need for the recipe for unison-blob.o
oferchen · Jul 6, 2023 · 4e0cf23 · 4e0cf23
2 parents 3cbf152 + b5e0512
commit 4e0cf23
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/Makefile.OCaml b/src/Makefile.OCaml
@@ -428,6 +428,10 @@ $(NAME)-blob.o: OCAMLLIBS += $(OCAMLLIBS_MAC)
 $(NAME)-blob.o: INCLFLAGS += $(INCLFLAGS_MAC)
 # Unfortunately -output-obj does not put .o files into the output, only .cmx
 # files, so we have to use $(LD) to take care of COBJS.
+# [2023-07] The limitations of -output-obj have been overcome by a new option
+# -output-complete-obj, available since OCaml 4.02.2. Still, this option can't
+# be used here because there is a bug which breaks linking on macOS when using
+# threads (needed by uimacbridge): https://github.com/ocaml/ocaml/issues/7933
 $(NAME)-blob.o: $$(CAMLOBJS) $(COBJS)
 	@echo Linking $@
 	$(CAMLC) -dstartup -output-obj -verbose -cclib -keep_private_externs $(CAMLFLAGS) -o u-b.o $(CAMLCFLAGS) $(CAMLLDFLAGS) $(CAMLLIBS) $(CLIBS) $(CAMLOBJS)