Remove inaccurate warning message (mlc-ai#1121)

This PR removes an inaccurate warning from mlc-ai#1086, which warns about `model_lib` overriding regardless of whether or not it's actually overridden. With this commit, we only warn if its value is not None.
octoml · Oct 24, 2023 · 9cb8e8e · 9cb8e8e
1 parent 2aa6809
commit 9cb8e8e
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/python/mlc_chat/chat_module.py b/python/mlc_chat/chat_module.py
@@ -356,22 +356,22 @@ def _get_chat_config(config_file_path: str, user_chat_config: Optional[ChatConfi
     final_chat_config = None
     with open(config_file_path, mode="rt", encoding="utf-8") as f:
         json_object = json.load(f)
-        final_chat_config = ChatConfig._from_json(json_object)
+        final_chat_config = ChatConfig._from_json(json_object)  # pylint: disable=protected-access
     if user_chat_config is not None:
         # We override using user's chat config
         for field in fields(user_chat_config):
             field_name = field.name
-            if field_name == "model_lib":
-                warn_msg = (
-                    'WARNING: Do not override "model_lib" in ChatConfig. '
-                    "This override will be ignored. "
-                    "Please use ChatModule.model_lib_path to override the full model library path instead."
-                )
-                warnings.warn(warn_msg)
-                continue
             field_value = getattr(user_chat_config, field_name)
             if field_value is not None:
-                setattr(final_chat_config, field_name, field_value)
+                if field_name == "model_lib":
+                    warn_msg = (
+                        'WARNING: Do not override "model_lib" in ChatConfig. '
+                        "This override will be ignored. Please use ChatModule.model_lib_path to "
+                        "override the full model library path instead."
+                    )
+                    warnings.warn(warn_msg)
+                else:
+                    setattr(final_chat_config, field_name, field_value)
     return final_chat_config