Skip to content

Commit

Permalink
Revert "internal/graphicsdriver/metal: Bug fix: Vsync didn't work on …
Browse files Browse the repository at this point in the history
…macOS"

This reverts commit 1dd13ae.

Reason: This caused FPS drop on macOS 12.0.1

Updates hajimehoshi#1885
Closes hajimehoshi#1939
  • Loading branch information
hajimehoshi committed Jan 8, 2022
1 parent 02d62af commit 7f569f3
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions internal/graphicsdriver/metal/view_macos.go
Original file line number Diff line number Diff line change
@@ -17,24 +17,11 @@

package metal

// #cgo CFLAGS: -x objective-c
// #cgo LDFLAGS: -framework Foundation
//
// #import <Foundation/Foundation.h>
//
// static int getMacOSMajorVersion() {
// NSOperatingSystemVersion version = [[NSProcessInfo processInfo] operatingSystemVersion];
// return (int)version.majorVersion;
// }
import "C"

import (
"github.com/hajimehoshi/ebiten/v2/internal/graphicsdriver/metal/mtl"
"github.com/hajimehoshi/ebiten/v2/internal/graphicsdriver/metal/ns"
)

var macOSMajorVersion = int(C.getMacOSMajorVersion())

func (v *view) setWindow(window uintptr) {
// NSView can be updated e.g., fullscreen-state is switched.
v.window = window
@@ -57,12 +44,6 @@ func (v *view) update() {
}

func (v *view) usePresentsWithTransaction() bool {
// On macOS 12 (or later), do not use presentsWithTransaction, or vsync doesn't work (#1885).
// This works only for Metal. Unfortunately, there is not a good solution for OpenGL.
if macOSMajorVersion >= 12 {
return false
}

// Disable presentsWithTransaction on the fullscreen mode (#1745).
return !v.vsyncDisabled
}

0 comments on commit 7f569f3

Please sign in to comment.