Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jwt regex validation error during skip-jwt-bearer-tokens flow #2888

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

stomekpe
Copy link
Contributor

@stomekpe stomekpe commented Dec 19, 2024

Change the jwttoken Regex

Description

Update jwt_session.go to just validate if each part of jwt token with {

Motivation and Context

Update jwt_session.go to just validate if each part of jwt token with {
Solve the issue:
#2887

How Has This Been Tested?

We test this on our local machine by building and running the oauth2-proxy.

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.
  • I have written tests for my code changes.

@stomekpe stomekpe requested a review from a team as a code owner December 19, 2024 15:33
@github-actions github-actions bot added the go label Dec 19, 2024
@tuunit tuunit changed the title Related to issue #2887 bugfix: when skip-jwt-bearer-tokens error on bearer token regex validation Jan 4, 2025
@tuunit tuunit added the bug label Jan 4, 2025
Copy link
Member

@tuunit tuunit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a CHANGELOG.md entry

@github-actions github-actions bot added the docs label Jan 13, 2025
@stomekpe
Copy link
Contributor Author

Please add a CHANGELOG.md entry

Done

tuunit
tuunit previously approved these changes Jan 15, 2025
@github-actions github-actions bot added the tests label Jan 15, 2025
@tuunit tuunit changed the title bugfix: when skip-jwt-bearer-tokens error on bearer token regex validation fix: jwt regex validation error during skip-jwt-bearer-tokens flow Jan 15, 2025
@tuunit tuunit merged commit f31e02c into oauth2-proxy:master Jan 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants