fix: self signed certificate handling in v7.7.0 #2803
Merged
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuunit
commented
Oct 5, 2024
pkg/validation/options.go
Outdated
| transport.TLSClientConfig = &tls.Config{ | ||
| RootCAs: pool, | ||
| MinVersion: tls.VersionTLS12, | ||
| } | ||
|
|
||
| http.DefaultClient = &http.Client{Transport: transport} | ||
| requests.DefaultHTTPClient = &http.Client{Transport: transport} |
There was a problem hiding this comment.
This breaks the user agent handling
There was a problem hiding this comment.
Suggested change
| requests.DefaultHTTPClient = &http.Client{Transport: transport} | |
| requests.DefaultHTTPClient.Next = transport |
tuunit
commented
Oct 5, 2024
pkg/requests/http.go
Outdated
| @@ -7,20 +7,22 @@ import ( | |||
| ) | |||
|
|
|||
| type userAgentTransport struct { | |||
| next http.RoundTripper | |||
| Next http.RoundTripper | |||
There was a problem hiding this comment.
Instead of exposing Next maybe a setter like function would be a better idea
4 tasks
tuunit
changed the title
kvanzuijlen
approved these changes
Oct 7, 2024
This was referenced Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #2570 introduced a custom user-agent for oauth2-proxy when making requests to the configured identity provider. This introduced custom
http.Clientandhttp.Transporthandling. Which wasn't reflected in the whole code base. Therefore with v7.7.0 the custom SSL handling for private CAs--provider-ca-filesor allowing insecure connections--ssl-insecure-skip-verifydidn't have any effect anymore because they were trying to configure golangshttp.DefaultClientinstead of our custom http client.Furthermore, I checked the whole code base for custom transport settings and think I got all related to this custom
http.Client.Fixes #2802
How Has This Been Tested?
--provider-ca-files--ssl-insecure-skip-verifyoauth2-proxy/<version>Checklist: