Skip to content

Commit

Permalink
Fix: emails handling in gitlab provider
Browse files Browse the repository at this point in the history
  • Loading branch information
Wilfried OLLIVIER committed Dec 4, 2020
1 parent d1d98f5 commit c3028b0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
5 changes: 2 additions & 3 deletions providers/gitlab.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,8 @@ import (
type GitLabProvider struct {
*ProviderData

Groups []string
Projects []*GitlabProject
EmailDomains []string
Groups []string
Projects []*GitlabProject

AllowUnverifiedEmail bool
}
Expand Down
7 changes: 0 additions & 7 deletions providers/gitlab_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ var _ = Describe("Gitlab Provider Tests", func() {
type emailsTableInput struct {
expectedError error
expectedValue string
domains []string
allowUnverifiedEmail bool
}

Expand All @@ -166,12 +165,6 @@ var _ = Describe("Gitlab Provider Tests", func() {
p.AllowUnverifiedEmail = in.allowUnverifiedEmail
session := &sessions.SessionState{AccessToken: "gitlab_access_token"}

if in.domains != nil {
if len(in.domains) >= 1 {
p.EmailDomains = in.domains
}
}

err := p.EnrichSession(context.Background(), session)

if in.expectedError != nil {
Expand Down

0 comments on commit c3028b0

Please sign in to comment.