Skip to content

Commit

Permalink
ipsec: remove warnings about now removed algorithms
Browse files Browse the repository at this point in the history
Redmine: #9247
  • Loading branch information
kprovost committed Nov 8, 2022
1 parent ee9bbad commit 807e911
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/usr/local/www/vpn_ipsec_phase1.php
Original file line number Diff line number Diff line change
Expand Up @@ -994,7 +994,7 @@ function build_eal_list() {
$section->add($group);
$counter += 1;
}
$section->addInput(new Form_StaticText('', ''))->setHelp('Note: Blowfish, 3DES, CAST128, MD5, SHA1, and DH groups 1, 2, 5, 22, 23, and 24 provide weak security and should be avoided.');
$section->addInput(new Form_StaticText('', ''))->setHelp('Note: SHA1 and DH groups 1, 2, 5, 22, 23, and 24 provide weak security and should be avoided.');

$btnaddopt = new Form_Button(
'algoaddrow',
Expand Down
9 changes: 2 additions & 7 deletions src/usr/local/www/vpn_ipsec_phase2.php
Original file line number Diff line number Diff line change
Expand Up @@ -734,11 +734,6 @@ function idinfo_to_pconfig($prefix, & $idinfo, & $pconfig) {
));
}


if ($i == $rows) {
$group->setHelp('Note: Blowfish, 3DES, and CAST128 provide weak security and should be avoided.');
}

$i++;
$section->add($group);
}
Expand All @@ -755,7 +750,7 @@ function idinfo_to_pconfig($prefix, & $idinfo, & $pconfig) {
$algo
))->addClass('multi')->setAttribute('id');

$group->setHelp('Note: Hash is ignored with GCM algorithms. MD5 and SHA1 provide weak security and should be avoided.');
$group->setHelp('Note: Hash is ignored with GCM algorithms. SHA1 provides weak security and should be avoided.');
}

$section->add($group);
Expand Down Expand Up @@ -1085,7 +1080,7 @@ function change_protocol() {
}

function change_aead() {
var notaead = ['AES', 'Blowfish', '3DES', 'CAST128'];
var notaead = ['AES'];
var arrayLength = notaead.length;
for (var i = 0; i < arrayLength; i++) {
if ($('#' + notaead[i]).prop('checked') || ($('#proto').val() != 'esp')) {
Expand Down

0 comments on commit 807e911

Please sign in to comment.