Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Unused AWS Gem from OpenXRTest #811

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Remove Unused AWS Gem from OpenXRTest #811

merged 2 commits into from
Dec 30, 2024

Conversation

AMZN-Gene
Copy link
Contributor

@AMZN-Gene AMZN-Gene commented Dec 26, 2024 •
edited
Loading

What does this PR do?

Remove unused AWS core gem from OpenXRTest
Need for Jenkins to build o3de/o3de#18571

How was this PR tested?

Built OpenXRTest using a o3de branch without AWS gems
Check AssetProcessor for any failed lua/scriptscanvas assets which may have been using AWS
Unfortunately, there were a lot of shader/material asset errors and a fatal "RPI System could not initialize" error on Editor startup, but this occurred in vanilla development branch as well as the AWS removal branch

@AMZN-Gene
Remove unused AWS core gem from OpenXRTest
2a20d90 
Signed-off-by: AMZN-Gene <genewalt@amazon.com>
@AMZN-Gene AMZN-Gene requested review from a team as code owners December 26, 2024 21:03
jhanca-robotecai
jhanca-robotecai reviewed Dec 27, 2024
View reviewed changes
Copy link
Contributor

@jhanca-robotecai jhanca-robotecai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never understood how things are versioned in O3DE, but shouldn't the project be bumped from 1.0.1 to 1.1.0?

@AMZN-Gene
Copy link
Contributor Author

AMZN-Gene commented Dec 27, 2024 •
edited
Loading

I never understood how things are versioned in O3DE, but shouldn't the project be bumped from 1.0.1 to 1.1.0?

Great point... I'm not quite sure either, but my guess is a version bump would be required when there's a possibility of incompatibility. For example, if the project was updated to work with an API change in the engine. I think in this case, since AWS Core was never actually used, this change can't ever break someone depending on which engine or gems they choose

Edit: Here's one instance where the version was bumped: 26d2d0a#diff-a965c05e1c154199128500e17e899aaa870a05de6564452d5b0f9218a4031512

Asking sig-release https://discord.com/channels/805939474655346758/816043864858951710/1322297486500692140

@AMZN-Gene
Bumping patch version; patch because no api has been changed
8be5e98 
Signed-off-by: Gene Walters <genewalt@amazon.com>
@AMZN-Gene
Copy link
Contributor Author

Bumping version patch number. Patch number is for changes that don't include any API updates.
https://docs.o3de.org/docs/contributing/release-versioning-and-terms/

@AMZN-Gene AMZN-Gene merged commit 43e688f into o3de:development Dec 30, 2024
2 checks passed
@AMZN-Gene AMZN-Gene deleted the OpenXr_RemoveAWSGem branch December 30, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forkercat forkercat forkercat approved these changes

@jhanca-robotecai jhanca-robotecai Awaiting requested review from jhanca-robotecai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AMZN-Gene @forkercat @jhanca-robotecai