Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collects failed assets on LyTestTools test failures #7368

Merged
merged 10 commits into from
Feb 10, 2022
Merged

Collects failed assets on LyTestTools test failures #7368

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f45ff64
Collects failed assets on LyTestTools test failures
evanchia-ly-sdets Feb 3, 2022
61e96d5
Changed query to all lines because of current asset logging bug
evanchia-ly-sdets Feb 3, 2022
e1fa9da
fixes per pr feedback
evanchia-ly-sdets Feb 4, 2022
089b7e8
testing removing change for AR failure
evanchia-ly-sdets Feb 5, 2022
1138879
Moved asset log artifact collection to after the results have been co…
evanchia-ly-sdets Feb 7, 2022
ce3da01
Adding debug line to help debug AR failure
evanchia-ly-sdets Feb 7, 2022
7b574fe
Made asset log collection non failing
evanchia-ly-sdets Feb 7, 2022
ee8e4b7
moved asset log collection after test result collection
evanchia-ly-sdets Feb 8, 2022
f76aac9
changed asset saving to non failing
evanchia-ly-sdets Feb 8, 2022
46a22d9
improved logging and comments
evanchia-ly-sdets Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Made asset log collection non failing 
Signed-off-by: evanchia <evanchia@amazon.com>
  • Loading branch information
@evanchia-ly-sdets
evanchia-ly-sdets committed Feb 7, 2022
commit 7b574fe1a214b9564e3d01b7d87a60c55cad3cc2
10 changes: 8 additions & 2 deletions Tools/LyTestTools/ly_test_tools/o3de/editor_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,7 +788,10 @@ def _exec_editor_test(self, request: Request, workspace: AbstractWorkspace, edit
else:
test_result = Result.Fail.create(test_spec, output, editor_log_content)
# Save assets with errors and warnings
editor_utils.save_failed_asset_joblogs(workspace)
try:
editor_utils.save_failed_asset_joblogs(workspace)
except Exception as e: # Purposefully broad
logger.warning(e)
except WaitTimeoutError:
output = editor.get_output()
editor.kill()
Expand Down Expand Up @@ -893,7 +896,10 @@ def _exec_editor_multitest(self, request: Request, workspace: AbstractWorkspace,
results[test_spec_name] = Result.Crash.create(crashed_result.test_spec, output, return_code,
crash_error, crashed_result.editor_log)
# Save assets with errors and warnings
editor_utils.save_failed_asset_joblogs(workspace)
try:
editor_utils.save_failed_asset_joblogs(workspace)
except Exception as e: # Purposefully broad
logger.warning(e)
except WaitTimeoutError:
editor.kill()
output = editor.get_output()
Expand Down