Lua Editor : Fix issue #14153 - Crash when closing file #18589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: LafLaurine <laurine.lafontaine@outlook.fr>
guillaume-haerinck
approved these changes
Jan 5, 2025
guillaume-haerinck
added
feature/scripting
lsemp3d
approved these changes
Jan 5, 2025
nick-l-o3de
approved these changes
Jan 6, 2025
gadams3
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix #14153. The Lua Editor was crashing when modifications were made to a file and closed. This was due to a manual deletion on a QWidget (Qt always have ownership of QWidget).
How was this PR tested?
Local build. Tested with the description of the issue :
=> The lua editor doesn't crash anymore